Feat: set relevant title in browser tab #928
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+76
to
+86
| if (!tree_name) { | ||
| tree_name = ''; | ||
| } | ||
|
|
||
| if (!git_branch) { | ||
| git_branch = ''; | ||
| } | ||
|
|
||
| const treeDetailsName = `${tree_name} ${git_branch}`.trim(); | ||
|
|
||
| return treeDetailsName === '' ? '-' : treeDetailsName; |
There was a problem hiding this comment.
Suggested change
| if (!tree_name) { | |
| tree_name = ''; | |
| } | |
| if (!git_branch) { | |
| git_branch = ''; | |
| } | |
| const treeDetailsName = `${tree_name} ${git_branch}`.trim(); | |
| return treeDetailsName === '' ? '-' : treeDetailsName; | |
| if (!tree_name && !git_branch) return '-'; | |
| if (!tree_name) return git_branch; | |
| if (!git_branch) return tree_name; | |
| return `${tree_name} ${git_branch}`; |
| @@ -266,6 +280,7 @@ function TreeDetails(): JSX.Element { | |||
| /> | |||
| } | |||
| > | |||
| <title>{`Tree: ${getTreeName(treeInfo.treeName, treeInfo.gitBranch)}`}</title> | |||
There was a problem hiding this comment.
this should be localized
| @@ -309,6 +309,8 @@ function HardwareDetails(): JSX.Element { | |||
| /> | |||
| } | |||
| > | |||
| <title>{`Hardware: ${hardwareId}`}</title> | |||
| @@ -268,6 +268,7 @@ const TestDetails = ({ | |||
| /> | |||
| } | |||
| > | |||
| <title>{`Test: ${data?.path}`}</title> | |||
| @@ -185,6 +185,7 @@ export const IssueDetails = ({ | |||
| /> | |||
| } | |||
| > | |||
| <title>{`Issue: ${data?.comment}`}</title> | |||
| @@ -229,6 +229,8 @@ const BuildDetails = ({ | |||
| /> | |||
| } | |||
| > | |||
| <title>{`Build: ${data?.config_name}`}</title> | |||
| @@ -185,6 +185,7 @@ export const IssueDetails = ({ | |||
| /> | |||
| } | |||
| > | |||
| <title>{`Issue: ${data?.comment}`}</title> | |||
There was a problem hiding this comment.
This might set the title to Issue: undefined. Check it out:
| @@ -0,0 +1,167 @@ | |||
| import { fixupConfigRules, fixupPluginRules } from "@eslint/compat"; | |||
There was a problem hiding this comment.
Don't forget to delete the old one
| @@ -10,7 +10,7 @@ | |||
| "coverage": "vitest run --coverage", | |||
| "storybook": "storybook dev -p 6006", | |||
| "build-storybook": "storybook build", | |||
| "lint-staged": "eslint --max-warnings=0 --ext .ts,.tsx,.js,.jsx src", | |||
| "lint-staged": "eslint --max-warnings=0 -c ./eslint.config.mjs", | |||
There was a problem hiding this comment.
Is it really necessary to specify the eslint config file path?
There was a problem hiding this comment.
I put this line to test when I update eslint. This is unnecessary and I will remove it. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.