feat(settings): enhance security and deployment settings #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
backend/kernelCI/settings.py
Outdated
|
|
||
| ENV_DEBUG = get_json_env_var("DEBUG", False) | ||
|
|
||
| if ENV_DEBUG is True or ENV_DEBUG == "True" or ENV_DEBUG == "true": |
There was a problem hiding this comment.
It would be nice to create a isTruly function to reuse this logic when we need it.
WilsonNet
force-pushed
the
fix/debug-mode
branch
from
e297da1 to
18e4e71
Compare
This commit introduces several changes to improve the security and deployment settings of the application. The `SECRET_KEY` is now fetched from environment variables, and the `DEBUG` setting is set to `False` by default, but can be overridden by an environment variable. Additionally, several security-related settings have been added, such as `SESSION_COOKIE_SECURE`, `CSRF_COOKIE_SECURE`, `SECURE_SSL_REDIRECT`, and `SECURE_HSTS_SECONDS`. The README.md file has also been updated with instructions on how to generate a `DJANGO_SECRET_KEY` and check if the application is ready for deployment. ```
WilsonNet
force-pushed
the
fix/debug-mode
branch
from
18e4e71 to
7cd3a14
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces several changes to improve the security and
deployment settings of the application. The
SECRET_KEYis now fetchedfrom environment variables, and the
DEBUGsetting is set toFalsebydefault, but can be overridden by an environment variable.
Additionally, several security-related settings have been added, such as
SESSION_COOKIE_SECURE,CSRF_COOKIE_SECURE,SECURE_SSL_REDIRECT,and
SECURE_HSTS_SECONDS.The README.md file has also been updated with instructions on how to
generate a
DJANGO_SECRET_KEYand check if the application is ready fordeployment.