refactor: make IssueList span 2 columns

Part of #870
kernelci · Feb 11, 2025 · 5548bea · 5548bea
1 parent 294d4e9
commit 5548bea
Show file tree

Hide file tree

Showing 4 changed files with 54 additions and 48 deletions.
diff --git a/dashboard/src/components/Cards/IssuesList.tsx b/dashboard/src/components/Cards/IssuesList.tsx
@@ -144,7 +144,13 @@ const IssuesList = ({
     </DumbListingContent>
   );
 
-  return <BaseCard title={titleElement} content={contentElement} />;
+  return (
+    <BaseCard
+      title={titleElement}
+      content={contentElement}
+      className="col-span-2"
+    />
+  );
 };
 
 const MemoizedIssuesList = memo(IssuesList);

diff --git a/dashboard/src/pages/TreeDetails/Tabs/Boots/BootsTab.tsx b/dashboard/src/pages/TreeDetails/Tabs/Boots/BootsTab.tsx
@@ -163,15 +163,6 @@ const BootsTab = ({ treeDetailsLazyLoaded }: BootsTabProps): JSX.Element => {
             archCompilerErrors={data.summary.boots.architectures}
             diffFilter={diffFilter}
           />
-          <MemoizedIssuesList
-            title={<FormattedMessage id="global.issues" />}
-            issues={data.summary.boots.issues}
-            failedWithUnknownIssues={data.summary.boots.unknown_issues}
-            diffFilter={diffFilter}
-            issueFilterSection="bootIssue"
-            detailsId={treeId}
-            pageFrom={RedirectFrom.Tree}
-          />
         </div>
         <div>
           <TreeCommitNavigationGraph />
@@ -181,6 +172,15 @@ const BootsTab = ({ treeDetailsLazyLoaded }: BootsTabProps): JSX.Element => {
             diffFilter={diffFilter}
           />
         </div>
+        <MemoizedIssuesList
+          title={<FormattedMessage id="global.issues" />}
+          issues={data.summary.boots.issues}
+          failedWithUnknownIssues={data.summary.boots.unknown_issues}
+          diffFilter={diffFilter}
+          issueFilterSection="bootIssue"
+          detailsId={treeId}
+          pageFrom={RedirectFrom.Tree}
+        />
       </DesktopGrid>
       <MobileGrid>
         <MemoizedStatusCard
@@ -200,15 +200,6 @@ const BootsTab = ({ treeDetailsLazyLoaded }: BootsTabProps): JSX.Element => {
               archCompilerErrors={data.summary.boots.architectures}
               diffFilter={diffFilter}
             />
-            <MemoizedIssuesList
-              title={<FormattedMessage id="global.issues" />}
-              issues={data.summary.boots.issues}
-              failedWithUnknownIssues={data.summary.boots.unknown_issues}
-              diffFilter={diffFilter}
-              issueFilterSection="bootIssue"
-              detailsId={treeId}
-              pageFrom={RedirectFrom.Tree}
-            />
           </div>
           <div>
             <MemoizedHardwareTested
@@ -217,6 +208,15 @@ const BootsTab = ({ treeDetailsLazyLoaded }: BootsTabProps): JSX.Element => {
               diffFilter={diffFilter}
             />
           </div>
+          <MemoizedIssuesList
+            title={<FormattedMessage id="global.issues" />}
+            issues={data.summary.boots.issues}
+            failedWithUnknownIssues={data.summary.boots.unknown_issues}
+            diffFilter={diffFilter}
+            issueFilterSection="bootIssue"
+            detailsId={treeId}
+            pageFrom={RedirectFrom.Tree}
+          />
         </InnerMobileGrid>
       </MobileGrid>
       <QuerySwitcher data={bootsData} status={fullStatus}>

diff --git a/dashboard/src/pages/TreeDetails/Tabs/Build/BuildTab.tsx b/dashboard/src/pages/TreeDetails/Tabs/Build/BuildTab.tsx
@@ -131,17 +131,6 @@ const BuildTab = ({ treeDetailsLazyLoaded }: BuildTab): JSX.Element => {
             toggleFilterBySection={toggleFilterBySection}
             diffFilter={diffFilter}
           />
-          <MemoizedIssuesList
-            title={<FormattedMessage id="global.issues" />}
-            issues={treeDetailsData.buildsIssues || []}
-            failedWithUnknownIssues={
-              treeDetailsData.failedBuildsWithUnknownIssues
-            }
-            diffFilter={diffFilter}
-            issueFilterSection="buildIssue"
-            detailsId={treeId}
-            pageFrom={RedirectFrom.Tree}
-          />
         </div>
         <div>
           <TreeCommitNavigationGraph />
@@ -151,6 +140,17 @@ const BuildTab = ({ treeDetailsLazyLoaded }: BuildTab): JSX.Element => {
             diffFilter={diffFilter}
           />
         </div>
+        <MemoizedIssuesList
+          title={<FormattedMessage id="global.issues" />}
+          issues={treeDetailsData.buildsIssues || []}
+          failedWithUnknownIssues={
+            treeDetailsData.failedBuildsWithUnknownIssues
+          }
+          diffFilter={diffFilter}
+          issueFilterSection="buildIssue"
+          detailsId={treeId}
+          pageFrom={RedirectFrom.Tree}
+        />
       </DesktopGrid>
       <MobileGrid>
         <TreeCommitNavigationGraph />

diff --git a/dashboard/src/pages/TreeDetails/Tabs/Tests/TestsTab.tsx b/dashboard/src/pages/TreeDetails/Tabs/Tests/TestsTab.tsx
@@ -161,15 +161,6 @@ const TestsTab = ({ treeDetailsLazyLoaded }: TestsTabProps): JSX.Element => {
             archCompilerErrors={summaryData.architectures}
             diffFilter={diffFilter}
           />
-          <MemoizedIssuesList
-            title={<FormattedMessage id="global.issues" />}
-            issues={summaryData.issues}
-            failedWithUnknownIssues={summaryData.unknown_issues}
-            diffFilter={diffFilter}
-            issueFilterSection="testIssue"
-            detailsId={treeId}
-            pageFrom={RedirectFrom.Tree}
-          />
         </div>
         <div>
           <TreeCommitNavigationGraph />
@@ -179,6 +170,15 @@ const TestsTab = ({ treeDetailsLazyLoaded }: TestsTabProps): JSX.Element => {
             diffFilter={diffFilter}
           />
         </div>
+        <MemoizedIssuesList
+          title={<FormattedMessage id="global.issues" />}
+          issues={summaryData.issues}
+          failedWithUnknownIssues={summaryData.unknown_issues}
+          diffFilter={diffFilter}
+          issueFilterSection="testIssue"
+          detailsId={treeId}
+          pageFrom={RedirectFrom.Tree}
+        />
       </DesktopGrid>
       <MobileGrid>
         <MemoizedStatusCard
@@ -198,15 +198,6 @@ const TestsTab = ({ treeDetailsLazyLoaded }: TestsTabProps): JSX.Element => {
               archCompilerErrors={summaryData.architectures}
               diffFilter={diffFilter}
             />
-            <MemoizedIssuesList
-              title={<FormattedMessage id="global.issues" />}
-              issues={summaryData.issues}
-              failedWithUnknownIssues={summaryData.unknown_issues}
-              diffFilter={diffFilter}
-              issueFilterSection="testIssue"
-              detailsId={treeId}
-              pageFrom={RedirectFrom.Tree}
-            />
           </div>
           <div>
             <MemoizedHardwareTested
@@ -215,6 +206,15 @@ const TestsTab = ({ treeDetailsLazyLoaded }: TestsTabProps): JSX.Element => {
               diffFilter={diffFilter}
             />
           </div>
+          <MemoizedIssuesList
+            title={<FormattedMessage id="global.issues" />}
+            issues={summaryData.issues}
+            failedWithUnknownIssues={summaryData.unknown_issues}
+            diffFilter={diffFilter}
+            issueFilterSection="testIssue"
+            detailsId={treeId}
+            pageFrom={RedirectFrom.Tree}
+          />
         </InnerMobileGrid>
       </MobileGrid>