Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix #415

Merged
merged 7 commits into from
Jul 23, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file modified search-index/characters_index.bin
Binary file not shown.
Binary file modified search-index/media_index.bin
Binary file not shown.
22 changes: 13 additions & 9 deletions src/merge.ts
Original file line number Diff line number Diff line change
Expand Up @@ -24,9 +24,19 @@ type CharacterWithId = WithId<Schema.Character>;
async function getFilteredCharacters(
{ userId, guildId }: { userId: string; guildId: string },
): Promise<WithId<CharacterWithId>[]> {
const { user, party } = await db.getInventory(guildId, userId);
const mongo = await db.newMongo().connect();

const characters = await db.getUserCharacters(userId, guildId);
const { user, party } = await db.getInventory(guildId, userId, mongo, true);

const likesCharactersIds = user.likes
?.map(({ characterId }) => characterId)
.filter(utils.nonNullable);

const likesMediaIds = user.likes
?.map(({ mediaId }) => mediaId)
.filter(utils.nonNullable);

const characters = await db.getUserCharacters(userId, guildId, mongo, true);

const partyIds = [
party.member1?.characterId,
Expand All @@ -36,13 +46,7 @@ async function getFilteredCharacters(
party.member5?.characterId,
];

const likesCharactersIds = user.likes
?.map(({ characterId }) => characterId)
.filter(utils.nonNullable);

const likesMediaIds = user.likes
?.map(({ mediaId }) => mediaId)
.filter(utils.nonNullable);
await mongo.close();

return characters
.filter((char) => {
Expand Down
24 changes: 13 additions & 11 deletions src/user.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1180,18 +1180,20 @@ function sum({
.then(async () => {
const mongo = await db.newMongo().connect();

const { user, ...inventory } = await db.getInventory(
const { user, party } = await db.getInventory(
guildId,
userId,
mongo,
true,
);

const likesCharactersIds = (user.likes ?? [])
.map(({ characterId }) => characterId);
const likesCharactersIds = user.likes
?.map(({ characterId }) => characterId)
.filter(utils.nonNullable);

const likesMediaIds = (user.likes ?? [])
.map(({ mediaId }) => mediaId);
const likesMediaIds = user.likes
?.map(({ mediaId }) => mediaId)
.filter(utils.nonNullable);

const characters = await db.getUserCharacters(
userId,
Expand All @@ -1201,11 +1203,11 @@ function sum({
);

const partyIds = [
inventory.party.member1Id,
inventory.party.member2Id,
inventory.party.member3Id,
inventory.party.member4Id,
inventory.party.member5Id,
party.member1?.characterId,
party.member2?.characterId,
party.member3?.characterId,
party.member4?.characterId,
party.member5?.characterId,
];

const embed = new discord.Embed();
Expand All @@ -1232,7 +1234,7 @@ function sum({
const r = char.rating as keyof typeof sum;

if (
partyIds.includes(char._id) ||
partyIds.includes(char.characterId) ||
likesCharactersIds.includes(char.characterId) ||
likesMediaIds.includes(char.mediaId)
) {
Expand Down
11 changes: 8 additions & 3 deletions src/utils.ts
Original file line number Diff line number Diff line change
Expand Up @@ -450,7 +450,7 @@ async function proxy(
url?: string,
size?: ImageSize,
): Promise<Attachment> {
let filename = url ? encodeURIComponent(basename(url)) : 'default.webp';
let filename = url ? basename(url) : 'default.webp';

const file = await _proxy(url ?? '', size);

Expand All @@ -462,10 +462,15 @@ async function proxy(
}
}

filename = filename.replaceAll('_', '-');
const asciiFilename = Array.from(filename)
.map((char) => char.charCodeAt(0))
.map((code) => code < 128 ? String.fromCharCode(code) : '-')
.join('')
.replaceAll('_', '-')
.replace(/\s+/g, '');

return {
filename,
filename: asciiFilename,
arrayBuffer: file.image,
type: file.format,
};
Expand Down
Loading