Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consider in-progress instances for UniformAcrossAZ update strategy #438

Merged
merged 13 commits into from
Mar 15, 2024
Merged

consider in-progress instances for UniformAcrossAZ update strategy #438

merged 13 commits into from
Mar 15, 2024

Conversation

shreyas-badiger
Copy link
Collaborator

@shreyas-badiger shreyas-badiger commented Mar 6, 2024

Currently, UniformAcrossAZ update strategy doesn't consider the in-progress instances. Because of this, we might end up cordoning more number of instances than the rollup.maxUnavailable.

@shreyas-badiger shreyas-badiger requested review from a team as code owners March 13, 2024 21:44
Copy link

codecov bot commented Mar 13, 2024

Codecov Report

Attention: Patch coverage is 82.97872% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 47.98%. Comparing base (7511a22) to head (6598147).

Files Patch % Lines
controllers/upgrade.go 82.97% 7 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #438      +/-   ##
==========================================
+ Coverage   43.75%   47.98%   +4.23%     
==========================================
  Files           7        7              
  Lines        1104     1119      +15     
==========================================
+ Hits          483      537      +54     
+ Misses        575      540      -35     
+ Partials       46       42       -4     
Flag Coverage Δ
unittests 47.98% <82.97%> (+4.23%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: sbadiger <shreyas_badiger@intuit.com>
Signed-off-by: sbadiger <shreyas_badiger@intuit.com>
Signed-off-by: sbadiger <shreyas_badiger@intuit.com>
Signed-off-by: sbadiger <shreyas_badiger@intuit.com>
Signed-off-by: sbadiger <shreyas_badiger@intuit.com>
Signed-off-by: sbadiger <shreyas_badiger@intuit.com>
Signed-off-by: sbadiger <shreyas_badiger@intuit.com>
Signed-off-by: sbadiger <shreyas_badiger@intuit.com>
Signed-off-by: sbadiger <shreyas_badiger@intuit.com>
Signed-off-by: sbadiger <shreyas_badiger@intuit.com>
Signed-off-by: sbadiger <shreyas_badiger@intuit.com>
Signed-off-by: sbadiger <shreyas_badiger@intuit.com>
Signed-off-by: sbadiger <shreyas_badiger@intuit.com>
@shreyas-badiger shreyas-badiger merged commit b48d119 into keikoproj:master Mar 15, 2024
4 checks passed
@shreyas-badiger shreyas-badiger mentioned this pull request Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants