Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CT-1653 Allow list same features as super admin for user with special feature #261

Merged
merged 1 commit into from
Aug 7, 2024
Merged

CT-1653 Allow list same features as super admin for user with special feature #261

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
110 changes: 109 additions & 1 deletion tests/FeaturesTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,116 @@
use Generator;
use Keboola\ManageApi\ClientException;

class FeaturesTest extends ClientTestCase
class FeaturesTest extends BaseFeatureTest
{
public function setUp(): void
{
parent::setUp();
$this->client->removeUserFeature($this->normalUser['email'], 'can-manage-features');
}

/**
* @dataProvider featureProvider
*/
public function testNormalUserCannotSeeTheSameFeatureAsSuperAdmin(array $createFeature, array $expectedFeature)
{
$createdFeature = $this->client->createFeature(
$createFeature['name'],
$createFeature['type'],
$createFeature['title'],
$createFeature['description'],
$createFeature['canBeManageByAdmin'],
$createFeature['canBeManagedViaAPI'],
);

$normalUserClient = $this->getNormalUserClient();
$features = $normalUserClient->listFeatures();

$featureFound = null;

foreach ($features as $feature) {
if ($expectedFeature['name'] === $feature['name']) {
$featureFound = $feature;
break;
}
}

if ($createdFeature['canBeManageByAdmin'] === false || $createdFeature['canBeManagedViaAPI'] === false) {
// feature should not be visible for normal user
$this->assertNull($featureFound);
try {
$normalUserClient->getFeature($createdFeature['id']);
$this->fail('Normal user should not see the feature');
} catch (ClientException $e) {
$this->assertEquals(404, $e->getCode());
}
} else {
$this->assertTrue($featureFound !== null);
$this->assertSame($expectedFeature['name'], $featureFound['name']);
$this->assertSame($expectedFeature['type'], $featureFound['type']);
$this->assertSame($expectedFeature['title'], $featureFound['title']);
$this->assertSame($expectedFeature['description'], $featureFound['description']);
$this->assertSame($expectedFeature['canBeManageByAdmin'], $featureFound['canBeManageByAdmin']);
$this->assertSame($expectedFeature['canBeManagedViaAPI'], $featureFound['canBeManagedViaAPI']);

$feature = $normalUserClient->getFeature($featureFound['id']);
$this->assertSame($expectedFeature['name'], $feature['name']);
$this->assertSame($expectedFeature['type'], $feature['type']);
$this->assertSame($expectedFeature['title'], $feature['title']);
$this->assertSame($expectedFeature['description'], $feature['description']);
$this->assertSame($expectedFeature['canBeManageByAdmin'], $feature['canBeManageByAdmin']);
$this->assertSame($expectedFeature['canBeManagedViaAPI'], $feature['canBeManagedViaAPI']);
}

$this->client->removeFeature($createdFeature['id']);
}

/**
* @dataProvider featureProvider
*/
public function testNormalUserWithFeatureCanSeeTheSameFeatureAsSuperAdmin(array $createFeature, array $expectedFeature)
{
$this->client->addUserFeature($this->normalUser['email'], 'can-manage-features');
$this->client->createFeature(
$createFeature['name'],
$createFeature['type'],
$createFeature['title'],
$createFeature['description'],
$createFeature['canBeManageByAdmin'],
$createFeature['canBeManagedViaAPI'],
);

$normalUserClient = $this->getNormalUserClient();
$features = $normalUserClient->listFeatures();

$featureFound = null;

foreach ($features as $feature) {
if ($expectedFeature['name'] === $feature['name']) {
$featureFound = $feature;
break;
}
}

$this->assertTrue($featureFound !== null);
$this->assertSame($expectedFeature['name'], $featureFound['name']);
$this->assertSame($expectedFeature['type'], $featureFound['type']);
$this->assertSame($expectedFeature['title'], $featureFound['title']);
$this->assertSame($expectedFeature['description'], $featureFound['description']);
$this->assertSame($expectedFeature['canBeManageByAdmin'], $featureFound['canBeManageByAdmin']);
$this->assertSame($expectedFeature['canBeManagedViaAPI'], $featureFound['canBeManagedViaAPI']);

$feature = $normalUserClient->getFeature($featureFound['id']);
$this->assertSame($expectedFeature['name'], $feature['name']);
$this->assertSame($expectedFeature['type'], $feature['type']);
$this->assertSame($expectedFeature['title'], $feature['title']);
$this->assertSame($expectedFeature['description'], $feature['description']);
$this->assertSame($expectedFeature['canBeManageByAdmin'], $feature['canBeManageByAdmin']);
$this->assertSame($expectedFeature['canBeManagedViaAPI'], $feature['canBeManagedViaAPI']);

$this->client->removeFeature($featureFound['id']);
}

/**
* @dataProvider featureProvider
*/
Expand Down
Loading