Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CT-1653 Allow list same features as super admin for user with special feature #261

Merged
merged 1 commit into from
Aug 7, 2024
Merged

CT-1653 Allow list same features as super admin for user with special feature #261

merged 1 commit into from
Aug 7, 2024

Conversation

romanbracinik
Copy link
Contributor

@romanbracinik romanbracinik commented Aug 6, 2024 •
edited
Loading

Jira: CT-1653
Connection PR: https://github.com/keboola/connection/pull/5200

Before asking for review make sure that:

Checklist

  • New client method(s) has tests
  • Apiary file is updated
  • You declared if there is a BC break or not (will affect next release of a client)

Release

  • I gave the PR a proper label:
    • major (BC break)
    • minor (new feature)
    • patch (backwards compatible fix)
    • no release (just test changes)

@romanbracinik romanbracinik force-pushed the ct-1653-allow-list-features-with-admin-feature branch from cf54651 to e6742bc Compare August 6, 2024 17:04
@romanbracinik romanbracinik changed the base branch from master to roman-fix-composer-in-CI August 6, 2024 17:05
@romanbracinik romanbracinik force-pushed the ct-1653-allow-list-features-with-admin-feature branch from e6742bc to 680b87f Compare August 6, 2024 17:05
Base automatically changed from roman-fix-composer-in-CI to master August 7, 2024 06:23
@romanbracinik romanbracinik force-pushed the ct-1653-allow-list-features-with-admin-feature branch from 680b87f to bc69496 Compare August 7, 2024 10:09
@romanbracinik romanbracinik force-pushed the ct-1653-allow-list-features-with-admin-feature branch from bc69496 to 61e0efe Compare August 7, 2024 10:27
@romanbracinik romanbracinik changed the title WIP tests CT-1653 Allow list same features as super admin for user with special feature Aug 7, 2024
@romanbracinik romanbracinik added the no release just test changes label Aug 7, 2024
@romanbracinik romanbracinik marked this pull request as ready for review August 7, 2024 10:49
@romanbracinik romanbracinik merged commit e0df1d0 into master Aug 7, 2024
3 checks passed
@romanbracinik romanbracinik deleted the ct-1653-allow-list-features-with-admin-feature branch August 7, 2024 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vojtabiberle vojtabiberle vojtabiberle approved these changes

Assignees
No one assigned
Labels
no release just test changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@romanbracinik @vojtabiberle