🐛 Bring back v1alpha1 versions of validating admission policy resources
#3147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…missionPolicyBindings to allow upgrades Signed-off-by: Marvin Beckers <marvin@kubermatic.com>
kcp-ci-bot
added
release-note-none
kcp-ci-bot
added
kind/api-change
|
/approve |
|
LGTM label has been added. Git tree hash: 0d048380a9a58909d8fb12781be3c4950fdb3cc7
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: xrstf The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kcp-ci-bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
#3140 removed
admissionregistrationv1alpha1.ValidatingAdmissionPoliciesandadmissionregistrationv1alpha1.ValidatingAdmissionPolicyBindingsfrom the CRDs used to bootstrap the cache server. This works fine on fresh kcp installations, but causes problems with kcp setups upgrading from v0.24.0. This brings back thev1alpha1versions to both CRDs as they exist in thev0.24.0git tag and adds them to the CRD. This allowed me to upgrade from an existing kcp setup initially set up with the last official release.Related issue(s)
Fixes #
Release Notes