Put nolint directives on things we cannot handle otherwise

Signed-off-by: Marvin Beckers <marvin@kubermatic.com>

pkg/reconciler/garbagecollector/garbagecollector_controller.go

@@ -264,6 +264,7 @@ func (c *Controller) startGarbageCollectorForLogicalCluster(ctx context.Context,
 		clusterName: clusterName,
 		queue:       workqueue.NewNamedRateLimitingQueue(workqueue.DefaultControllerRateLimiter(), "quota-"+clusterName.String()),
 		work: func(ctx context.Context) {
+			//nolint:errcheck
 			garbageCollector.ResyncMonitors(ctx, c.dynamicDiscoverySharedInformerFactory)
 		},
 	}
@@ -286,6 +287,7 @@ func (c *Controller) startGarbageCollectorForLogicalCluster(ctx context.Context,
 	// Do this in a goroutine to avoid holding up a worker in the event ResyncMonitors stalls for whatever reason
 	go func() {
 		// Make sure the GC monitors are synced at least once
+		//nolint:errcheck
 		garbageCollector.ResyncMonitors(ctx, c.dynamicDiscoverySharedInformerFactory)
 
 		go garbageCollector.Run(ctx, c.workersPerLogicalCluster)

pkg/reconciler/topology/partitionset/resources.go

@@ -51,11 +51,11 @@ func generatePartitionName(name string, matchLabels map[string]string, dimension
 	for _, label := range labels {
 		name = name + "-" + strings.ToLower(matchLabels[label])
 	}
-	name = name[:min(validation.DNS1123SubdomainMaxLength-1, len(name))]
+	name = name[:minimum(validation.DNS1123SubdomainMaxLength-1, len(name))]
 	return name
 }
 
-func min(a, b int) int {
+func minimum(a, b int) int {
 	if a < b {
 		return a
 	}

pkg/server/apiextensions_test.go

@@ -108,10 +108,12 @@ func TestDecorateCRDWithBinding(t *testing.T) {
 
 			for _, expCondition := range tt.expectedConditions {
 				cond := apiextensionshelpers.FindCRDCondition(newCrd, expCondition.Type)
+				//nolint:staticcheck
 				if cond == nil {
 					t.Fatalf("Missing status condition %v", expCondition.Type)
 				}
 
+				//nolint:staticcheck
 				if cond.Status != expCondition.Status {
 					t.Errorf("expect condition status %q, got %q for type %s", expCondition.Status, cond.Status, cond.Type)
 				}