[Enhancement kbss-cvut/termit-ui#473] Annotator: resolve "memory leak" and reset filter on occurrence marking #499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ledsoft
approved these changes
Aug 8, 2024
| const action = { type: ActionType.ANNOTATOR_LOAD_TERM }; | ||
| return (dispatch: ThunkDispatch, getState: GetStoreState) => { | ||
| // TODO: remove throwIfAborted null check (problem with NodeJS version) support from 17.3.0 (Released 2021-12-17) |
There was a problem hiding this comment.
Let's bump minimum required Node version to 18. I recently resolved an issue with building TermIt on 20 and later, so there is no reason to stick with such an old version. Browser support is also good (since start of 2022).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #473
fixes updating the state of an unmounted element