Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement #482] Support sending invitation links to new users #483

Merged
merged 7 commits into from
Jul 25, 2024

Conversation

lukaskabc
Copy link
Collaborator

Resolves #482

Copy link

gitguardian bot commented Jul 23, 2024

⚠️ GitGuardian has uncovered 7 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

Since your pull request originates from a forked repository, GitGuardian is not able to associate the secrets uncovered with secret incidents on your GitGuardian dashboard.
Skipping this check run and merging your pull request will create secret incidents on your GitGuardian dashboard.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
- - Generic Password 291e378 src/i18n/cs.ts View secret
- - Generic Password 8ca5a30 src/i18n/cs.ts View secret
- - Generic Password 8ca5a30 src/i18n/cs.ts View secret
- - Generic Password 291e378 src/i18n/cs.ts View secret
- - Generic Password 8ca5a30 src/i18n/cs.ts View secret
- - Generic Password 291e378 src/i18n/cs.ts View secret
- - Generic Password 8ca5a30 src/i18n/cs.ts View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Copy link
Contributor

@ledsoft ledsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the inline comments. Mostly minor stuff, the main issue I have is the change of the HTTP method for creating an account.

@lukaskabc lukaskabc force-pushed the lukaskabc/Enhancement-482 branch from 28f1b32 to 291e378 Compare July 24, 2024 07:59
@lukaskabc lukaskabc requested a review from ledsoft July 24, 2024 08:14
Copy link
Contributor

@ledsoft ledsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more round of comments after actually testing the functionality.

@ledsoft ledsoft merged commit ed25d8d into kbss-cvut:development Jul 25, 2024
5 of 6 checks passed
@ledsoft ledsoft linked an issue Jul 25, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support sending invitation links to new users
2 participants