Test dns bicep #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add Maestro Dry Runs
Remove duplicate env entry
Add Dry Run for Hypershift Operator
follows up on Azure#1040 Signed-off-by: Gerd Oberlechner <goberlec@redhat.com>
Use pipeline Add Dry Run
Signed-off-by: Gerd Oberlechner <goberlec@redhat.com>
Refactor deployments
use latest PKO
Signed-off-by: Gerd Oberlechner <goberlec@redhat.com>
Implement collection GETs for node pools
Add "externalID" and "internalID" parameters so the returned document is a minimum valid OperationDocument for writing.
The operation item must now be created in the database prior to calling ExposeOperation. ExposeOperation does all its processing in a database update callback. This is because there is an increasing number of cases where we create an implicit async operation with no visible status endpoint. Calling ExposeOperation makes an implicit async operation explicit, with a status endpoint for ARM to poll. Hence the rename. The tradeoff is explicit asyncrhonous operations now require two database operations (create and update) but it helps make the RP logic cleaner. This could possibly be mitigated in the future by using Cosmos DB's transactional batch operations, but it's gonna take some serious refactoring to get there.
CancelActiveOperation marks the status of any active operation on the resource as canceled.
Will be reusing DeleteResource for subscription deletion. Add database bookkeeping for the resource and any child resources. This includes creating implicit operations for each resource being deleted. The caller may then expose the returned operation ID.
By my read of the Subscription Lifecycle API Reference [1], we should favor 200 OK over 201 Created when creating or updating a subscription. [1] https://github.com/cloud-and-ai-microsoft/resource-provider-contract/blob/master/v1.0/subscription-lifecycle-api-reference.md#response
Called when a subscription is deleted. The method is idempotent in case of multiple subscription PUT requests.
* introduce configuration option for the frontend cert issuer * register issuers with SVC KV * move frontend cert creation into the svc-cluster step, so after the SVC KV issuer registration has happened for sure Signed-off-by: Gerd Oberlechner <goberlec@redhat.com>
replace hardcoded tenant and subscription IDs with actual lookups from the current azure session. this way these scripts can be used in other environments as well. Signed-off-by: Gerd Oberlechner <goberlec@redhat.com>
running pipelines via templatize.sh will honor the PERSIST env var Signed-off-by: Gerd Oberlechner <goberlec@redhat.com>
* add controlPlaneOperator MI, remove network/ingres MI from DP * add cluster-api-azure and fix control-plane key * update managed identitites in cluster creation script
- add SP/App IDs - add MCE config (+ require it in the schema) - update CS, imagesync, RP image tags - fix imagesync RG - enable maestro azure DB usage Signed-off-by: Gerd Oberlechner <goberlec@redhat.com>
the ACM operator version we need are listed in the registry.redhat.io/redhat/redhat-operator-index:v4.16 catalog image, not the 4.17 one Signed-off-by: Gerd Oberlechner <goberlec@redhat.com>
ARO-14453 | Add Frontend validation for user-assigned identity fields and relevant test cases
grafana registration yields an error dín the GH action pipelines. disabling this for now allows us to run pipelines for the time being until we figure out the details ``` ERROR: 401 Client Error: Unauthorized for url: https://arohcp-dev-c9g7a4fjanb0c4gc.eus.grafana.azure.com/api/datasources ``` Signed-off-by: Gerd Oberlechner <goberlec@redhat.com>
…ure#1182) * fix: fix capz control plane operator name in cluster creation script It should be cluster-api-azure instead of cluster-azure-api * doc: update dev setup doc to include up to date MIs for cluster creation
frontend: Plumb the OutboundType API value through to CS
Update 4.18 as well
* prepare output chaining * introduce output bicep templates for global, regional and svc level * move CS MI ID lookup into svc level output template * mark svc output step as `outputOnly` Signed-off-by: Gerd Oberlechner <goberlec@redhat.com> * don't rely on schema fields to carry output chaining propagation Signed-off-by: Gerd Oberlechner <goberlec@redhat.com> --------- Signed-off-by: Gerd Oberlechner <goberlec@redhat.com>
Delete unused metrics target
… repo (Azure#1191) Co-authored-by: Jonathan Chang <jonachang@microsoft.com>
Signed-off-by: Gerd Oberlechner <goberlec@redhat.com>
the grafana ID is required in regional deployments and this change makes the resource ID available via output chaining from the global scope Signed-off-by: Gerd Oberlechner <goberlec@redhat.com>
Add missing rg scope to custom role
Use MSI mock role
we only need one pipeline for global resources to manage DNS, grafana and ACRs. therefore we merge the respective pipeline files and reduce to a single ADO pipeline to execute it Signed-off-by: Gerd Oberlechner <goberlec@redhat.com>
* move acrpull to svc cluster pipeline Signed-off-by: Gerd Oberlechner <goberlec@redhat.com> * move acrpull into mgmt pipeline Signed-off-by: Gerd Oberlechner <goberlec@redhat.com> * fix pipeline deps Signed-off-by: Gerd Oberlechner <goberlec@redhat.com> --------- Signed-off-by: Gerd Oberlechner <goberlec@redhat.com>
Add grafana admin and re-enable grafana/amw integration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Jira:
Link to demo recording:
Special notes for your reviewer