Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Critical vulnerability for package golang.org/x/crypto found in latest version of cdk-notifier. #185

Open
passbt opened this issue Jan 3, 2025 · 5 comments

Comments

@passbt
Copy link

passbt commented Jan 3, 2025

Hello, I'm installing the latest version, v2.13.5, of cdk-notifier and Trivy is detecting a critical vulnerability for golang.org/x/crypto, v0.16.0, package that is present packaged in cdk-notifier. When do you anticipate your Renovate bot will get this patched? I didn't see mention of it on your issue dashboard. The fix is in v0.31.0 of the crypto package. Here is a link to the Go vulnerability report: https://pkg.go.dev/vuln/GO-2024-3321.

Thank you!

@passbt passbt changed the title Vulnerability Report: GO-2024-3321 present in Vulnerability Report: GO-2024-3321 present in cdk-notifier Jan 3, 2025
@passbt passbt changed the title Vulnerability Report: GO-2024-3321 present in cdk-notifier Critical vulnerability for package golang.org/x/crypto found in latest version of cdk-notifier. Jan 3, 2025
@karlderkaefer
Copy link
Owner

I can confirm the vulnerability is listed in dependabot alerts. This is due to the fact that the PR for updating the gitlab client failed #117 thanks for raising the issue. I can check tomorrow

@karlderkaefer
Copy link
Owner

karlderkaefer commented Jan 4, 2025

@passbt I updated all dependencies to latest see #171 It has resolved 2 out 3 security alerts. However the problem with x/crypto stays, since sprig module is still using old x/crypto version . Can you create also create a github issue there?

go mod graph | grep golang.org/x/crypto
github.com/karlderkaefer/cdk-notifier golang.org/x/crypto@v0.26.0
github.com/Masterminds/sprig/v3@v3.3.0 golang.org/x/crypto@v0.26.0
github.com/spf13/afero@v1.11.0 golang.org/x/crypto@v0.16.0
github.com/spf13/viper@v1.19.0 golang.org/x/crypto@v0.21.0
golang.org/x/crypto@v0.26.0 golang.org/x/net@v0.21.0
golang.org/x/crypto@v0.26.0 golang.org/x/sys@v0.23.0
golang.org/x/crypto@v0.26.0 golang.org/x/term@v0.23.0
golang.org/x/crypto@v0.26.0 golang.org/x/text@v0.17.0

@karlderkaefer
Copy link
Owner

I have a PR ready in case the upstream request takes too long #186 but it would be better to fix it upstream.

@passbt
Copy link
Author

passbt commented Jan 4, 2025

I agree.

@passbt
Copy link
Author

passbt commented Feb 3, 2025

I have a PR ready in case the upstream request takes too long #186 but it would be better to fix it upstream.

I'm not sure how long you wanted to give them, but are you opened to moving forward with your PR? If I remember right, they only review changes a few times a year in the upstream project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants