Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve procountor import parsing #138

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

annttu
Copy link
Contributor

@annttu annttu commented Jul 9, 2018

Filter empty and unknown rows from Procountor import csv.

@codecov-io
Copy link

codecov-io commented Jul 9, 2018

Codecov Report

Merging #138 into master will increase coverage by 0.13%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #138      +/-   ##
==========================================
+ Coverage   74.67%   74.81%   +0.13%     
==========================================
  Files          53       53              
  Lines        5173     5201      +28     
==========================================
+ Hits         3863     3891      +28     
  Misses       1310     1310
Impacted Files Coverage Δ
membership/management/commands/csvbills.py 91.57% <100%> (+0.71%) ⬆️
membership/tests.py 98.11% <100%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9bfdb40...228aac0. Read the comment docs.

Copy link
Contributor

@Wraithh Wraithh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@annttu annttu force-pushed the fix-procountor-import branch from 765ee95 to 3f70442 Compare November 10, 2018 11:02
@annttu annttu force-pushed the fix-procountor-import branch from 3f70442 to 228aac0 Compare November 10, 2018 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants