Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(FEC-13979): fix default caption alignment #781

Merged
merged 1 commit into from
Jun 9, 2024
Merged

fix(FEC-13979): fix default caption alignment #781

merged 1 commit into from
Jun 9, 2024

Conversation

semarche-kaltura
Copy link
Contributor

Description of the Changes

Overwrite default caption alignment (case when caption cues has native alignment but user set custom alignment in caption menu)

resolves: https://kaltura.atlassian.net/browse/FEC-13979

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@MosheMaorKaltura MosheMaorKaltura merged commit 9293ec7 into master Jun 9, 2024
11 checks passed
@semarche-kaltura semarche-kaltura changed the title fix(XDR-3359): fix default caption alignment fix(FEC-13979): fix default caption alignment Jun 9, 2024
@semarche-kaltura semarche-kaltura deleted the XDR-3359-default-caption-alignment branch June 9, 2024 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MosheMaorKaltura MosheMaorKaltura MosheMaorKaltura approved these changes

@JonathanTGold JonathanTGold Awaiting requested review from JonathanTGold

@lianbenjamin lianbenjamin Awaiting requested review from lianbenjamin

@SivanA-Kaltura SivanA-Kaltura Awaiting requested review from SivanA-Kaltura

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@semarche-kaltura @MosheMaorKaltura