From 5f10b16a4aba081176d680db80c248aa2fef1e68 Mon Sep 17 00:00:00 2001 From: inbalvasserman <55684552+inbalvasserman@users.noreply.github.com> Date: Wed, 29 May 2024 12:15:55 +0300 Subject: [PATCH] Revert "fix(SUP-42112): Advanced Caption Settings not working in iOS" (#779) Reverts kaltura/playkit-js#773 --- src/track/external-captions-handler.ts | 2 +- src/track/text-style.ts | 7 ------- 2 files changed, 1 insertion(+), 8 deletions(-) diff --git a/src/track/external-captions-handler.ts b/src/track/external-captions-handler.ts index f407a674..53f25764 100644 --- a/src/track/external-captions-handler.ts +++ b/src/track/external-captions-handler.ts @@ -32,7 +32,7 @@ const VTT_POSTFIX: string = 'vtt'; class ExternalCaptionsHandler extends FakeEventTarget { public static applyNativeTextTrackStyles(sheet: CSSStyleSheet, styles: TextStyle, containerId: string, engineClassName: string): void { - sheet.insertRule(`#${containerId} video.${engineClassName}::-webkit-media-text-track-display { ${styles.webkitTextCSS()} }`, 0); + sheet.insertRule(`#${containerId} video.${engineClassName}::-webkit-media-text-track-display { text-align: ${styles.textAlign}!important; }`, 0); sheet.insertRule(`#${containerId} video.${engineClassName}::cue { ${styles.toCSS()} }`, 0); } diff --git a/src/track/text-style.ts b/src/track/text-style.ts index a9df0233..4fb7b4d0 100644 --- a/src/track/text-style.ts +++ b/src/track/text-style.ts @@ -284,17 +284,10 @@ class TextStyle { attributes.push('font-family: ' + this.fontFamily); attributes.push('color: ' + TextStyle.toRGBA(this.fontColor, this.fontOpacity)); attributes.push('background-color: ' + TextStyle.toRGBA(this.backgroundColor, this.backgroundOpacity)); - attributes.push('font-size: ' + this.fontSize); attributes.push('text-shadow: ' + this.getTextShadow()); return attributes.join('!important; '); } - public webkitTextCSS(): string { - const attributes: Array = []; - attributes.push('text-align: ' + this.textAlign); - attributes.push(`background: linear-gradient(0deg, ${TextStyle.toRGBA(this.backgroundColor, this.fontOpacity)}, ${TextStyle.toRGBA(this.backgroundColor, this.fontOpacity)})`); - return attributes.join('!important; '); - } /** * clones the textStyle object * @returns {TextStyle} the cloned textStyle object