Skip to content

Commit

Permalink
fix(SUP-28484): make chapters thumbnails actionable (#4239)
Browse files Browse the repository at this point in the history
- add description to slides/chapters area label;
- use role "button" to define clickable item
  • Loading branch information
semarche-kaltura authored Aug 2, 2021
1 parent 86cfa4c commit e8dc749
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 1 deletion.
2 changes: 2 additions & 0 deletions modules/KalturaSupport/KalturaSupport.i18n.json
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,8 @@
"ks-chapters-locate-active-media": "Locate current slide",
"ks-chapters-slider-locator": "Slide Locator",
"ks-chapters-toggle-chapter": "Expand\/collapse chapter",
"ks-chapters-chapter": "Chapter",
"ks-chapters-slide": "Slide",
"ks-chapters-toggle-all-chapter": "Expand\/collapse all chapters",
"ks-chapters-chapterNumber": "Chapter number",
"ks-chapters-chapter-start-time": "Chapter start time",
Expand Down
4 changes: 3 additions & 1 deletion modules/KalturaSupport/components/chapters/chapters.js
Original file line number Diff line number Diff line change
Expand Up @@ -458,7 +458,9 @@
chapterToggle: gM("ks-chapters-toggle-chapter"),
slideNumber: gM("ks-chapters-slideNumber"),
slideStartTime: gM("ks-chapters-slide-start-time"),
slideDuration: gM("ks-chapters-slide-duration")
slideDuration: gM("ks-chapters-slide-duration"),
chapter: gM("ks-chapters-chapter"),
slide: gM("ks-chapters-slide")

};
return metaData;
Expand Down
2 changes: 2 additions & 0 deletions modules/KalturaSupport/components/chapters/chapters.tmpl.html
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
<li class="mediaBox chapterBox collapsed"
role="button"
aria-label="<%=meta.titles.chapter%> - <%=mediaItem.description%>"
data-chapter-index="<%=mediaItem.chapterNumber%>"
data-obj-id="<%=mediaItem.id%>"
data-starttime="<%=mediaItem.startTime%>"
Expand Down
2 changes: 2 additions & 0 deletions modules/KalturaSupport/components/chapters/slides.tmpl.html
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
<li class="mediaBox slideBox <% if (mediaItem.chapterNumber !== -1){%>collapsed<%}%>"
role="button"
aria-label="<%=meta.titles.slide%> - <%=mediaItem.description%>"
data-chapter-index="<%=mediaItem.chapterNumber%>"
data-slide-index="<%=mediaItem.slideNumber%>"
data-box-type="<%=mediaItem.type%>"
Expand Down

0 comments on commit e8dc749

Please sign in to comment.