Enh/use jlls

[kalmarek]

I'm not sure if libarb is exported from Arb_jll, but this seems to work? should we add const libarb = Arb_jll.libarb just below using Arb_jll?

[codecov]

Codecov Report

Merging #31 into master will increase coverage by 0.81%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master      #31      +/-   ##
==========================================
+ Coverage   95.92%   96.73%   +0.81%     
==========================================
  Files           9        9              
  Lines         270      276       +6     
==========================================
+ Hits          259      267       +8     
+ Misses         11        9       -2     

Flag	Coverage Δ
#unittests	96.73% <ø> (+0.81%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
src/Arblib.jl	100.00% <ø> (ø)
src/arb_types.jl	100.00% <0.00%> (ø)
src/arbcall.jl	98.90% <0.00%> (+1.14%)	⬆️
src/show.jl	95.12% <0.00%> (+2.43%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 52ead4b...e3023b3. Read the comment docs.

[saschatimme]

I guess, if this works, then there is no need to define this additionally :)

[kalmarek]

ok, but now my question is what is the purpose of LoadFlint.jl? It just loads FLINT_jll and sets the memory allocation functions, but so does FLINT_jll. Compare:
https://github.com/JuliaBinaryWrappers/FLINT_jll.jl/blob/22298d2bc6788ae72cb4ac921d2a71c8593b876a/src/wrappers/x86_64-linux-gnu.jl#L54

https://github.com/oscar-system/LoadFlint.jl/blob/6012ee2c7f553b6cd5aff69da66433a1f621acae/src/LoadFlint.jl#L46

?

[saschatimme]

I think this is relevant oscar-system/LoadFlint.jl#7

[kalmarek]

I can't really read through that thread, can you summarize what is the difference? I just tested with only FLINT_jll, all 1.3, 1.4 and 1.5 pass.

[Joel-Dahne]

Does it work to load for example Nemo and Arblib at the same time if we use Flint_jll instead?

[kalmarek]

please tell me what is the real difference between those __init__s 🤣
https://github.com/JuliaBinaryWrappers/FLINT_jll.jl/blob/22298d2bc6788ae72cb4ac921d2a71c8593b876a/src/wrappers/x86_64-linux-gnu.jl#L29
https://github.com/oscar-system/LoadFlint.jl/blob/6012ee2c7f553b6cd5aff69da66433a1f621acae/src/LoadFlint.jl#L20

to me they're doing the same thing, but LoadFlint also tries to avoid several libgmps loaded. I don't think it's relevant for julia>=1.3 since there we explicitly using GMP_jll.

Also based on the discussion in the thread linked by @saschatimme (see oscar-system/LoadFlint.jl#7 (comment)) it seems that LoadFlint will use the broadest compat on FLINT_jll and it's up to the packages using it to specify the compat versions.
Maybe then we still need to explicitly depend on FLINT_jll for particular version?