commands: improve typings, WIP

kaelzhang · Dec 12, 2024 · 59e3879 · 59e3879
1 parent 6708894
commit 59e3879
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 6 deletions.
diff --git a/stock_pandas/commands/base.py b/stock_pandas/commands/base.py
@@ -3,8 +3,8 @@
     Optional,
     Callable,
     List,
-    Dict,
-    Any
+    Union,
+    Dict
 )
 
 from numpy import ndarray
@@ -16,10 +16,14 @@
 
 ReturnType = Tuple[ndarray, int]
 CommandFormula = Callable[..., ReturnType]
+CommandArg = Union[str, int, float]
 CommandArgs = List[
-    Tuple[
-        Optional[Any],
-        Optional[Callable]
+    Union[
+        Tuple[
+            Optional[CommandArg],
+            Optional[Callable[..., CommandArg]]
+        ],
+        CommandArg
     ]
 ]
 

diff --git a/stock_pandas/commands/trend_following.py b/stock_pandas/commands/trend_following.py
@@ -155,7 +155,7 @@ def macd_histogram(
 # bbi
 # ----------------------------------------------------
 
-def bbi(df, s, a, b, c, d) -> ReturnType:
+def bbi(df, _, a, b, c, d) -> ReturnType:
     """Calculates BBI (Bull and Bear Index) which is the average of
     ma:3, ma:6, ma:12, ma:24 by default
     """