Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closes #790 - Update RestController annotations to be correct and consistent #795

Merged
merged 3 commits into from
Apr 3, 2025
Merged

Closes #790 - Update RestController annotations to be correct and consistent #795

merged 3 commits into from
Apr 3, 2025
+10 −72

Conversation

leantios
Copy link
Contributor

@leantios leantios commented Apr 2, 2025 •
edited
Loading

Thanks for your PR! Please fill out the following list :)

  • I put the ticket or multiple tickets in review
  • Commit message format → Will squash on merge
  • Sonarcloud link : https://github.com/leantios/kadai-fork/runs/39924861809
  • No documentation update needed
  • Link to PR with documentation update: <add the link here>
  • No Release Notes needed
  • Release Notes :

bruderj15
bruderj15 requested changes Apr 2, 2025
View reviewed changes
Copy link
Member

@bruderj15 bruderj15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might also check all other controller endpoints to see if these annotations are missing elsewhere.

@bruderj15 bruderj15 linked an issue Apr 2, 2025 that may be closed by this pull request
Update RestController annotations to be correct and consistent #790
Closed
@leantios leantios changed the title Closes #790 - Add @PostMapping with path to TaskController::requestChanges Closes #790 - Update RestController annotations to correct and consistent Apr 3, 2025
@leantios leantios changed the title Closes #790 - Update RestController annotations to correct and consistent Closes #790 - Update RestController annotations to be correct and consistent Apr 3, 2025
@leantios leantios requested a review from bruderj15 April 3, 2025 14:12
@leantios leantios merged commit bfab3d9 into kadai-io:master Apr 3, 2025
35 checks passed
@leantios leantios deleted the kadai-io#790/addPostMapping branch April 3, 2025 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bruderj15 bruderj15 bruderj15 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update RestController annotations to be correct and consistent
2 participants
@leantios @bruderj15