Fix finding Gateway VPC Endpoints by id #595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test failures look unrelated to this change. Looks like an attempt to fix them was made in #593 ? |
|
@alexjfisher Thank you for your contribution! I've changed the version of Ruby I support. Could you merge the |
For approximately the last month, the AWS `describe_vpc_endpoints` API has been broken when fetching _Gateway_ VPC endpoints by id using the `filters` option. Using the `vpc_endpoint_ids` option instead does still work, (for both Interface and Gateway endpoints). Fixes k1LoW#594
|
@k1LoW Rebased and all the tests now passing :) |
|
@alexjfisher Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For approximately the last month, the AWS
describe_vpc_endpointsAPI has been broken when fetching Gateway VPC endpoints by id using thefiltersoption.Using the
vpc_endpoint_idsoption instead does still work, (for both Interface and Gateway endpoints).Fixes #594