Skip to content

Commit

Permalink
[apache#1585] improvement(UI): use browser title instead of tooltip o…
Browse files Browse the repository at this point in the history
…f icon button (apache#1588)

### What changes were proposed in this pull request?

Before:
<img width="146" alt="image"
src="https://github.com/datastrato/gravitino/assets/17310559/c2b9fc69-9a07-42e9-8827-c3fd864415ff">

After:
<img width="151" alt="image"
src="https://github.com/datastrato/gravitino/assets/17310559/928d9e97-4e4a-4254-b9b5-e73f39a00890">


### Why are the changes needed?

Fix: apache#1585

### Does this PR introduce _any_ user-facing change?

N/A

### How was this patch tested?

N/A
  • Loading branch information
ch3yne authored Jan 17, 2024
1 parent 820d45e commit df2d622
Showing 1 changed file with 27 additions and 30 deletions.
57 changes: 27 additions & 30 deletions web/app/(home)/MetalakeList.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import { useEffect, useCallback, useState } from 'react'

import Link from 'next/link'

import { Box, Grid, Card, IconButton, Typography, Tooltip } from '@mui/material'
import { Box, Grid, Card, IconButton, Typography } from '@mui/material'
import { DataGrid } from '@mui/x-data-grid'

import Icon from '@/components/Icon'
Expand Down Expand Up @@ -139,35 +139,32 @@ const MetalakeList = () => {
headerName: 'Actions',
renderCell: ({ row }) => (
<>
<Tooltip title='Details' placement='top'>
<IconButton
size='small'
sx={{ color: theme => theme.palette.text.secondary }}
onClick={() => handleShowDetails(row)}
>
<Icon icon='bx:show-alt' />
</IconButton>
</Tooltip>

<Tooltip title='Edit' placement='top'>
<IconButton
size='small'
sx={{ color: theme => theme.palette.text.secondary }}
onClick={() => handleShowEditDialog(row)}
>
<Icon icon='mdi:square-edit-outline' />
</IconButton>
</Tooltip>

<Tooltip title='Delete' placement='top'>
<IconButton
size='small'
sx={{ color: theme => theme.palette.error.light }}
onClick={() => handleDeleteMetalake(row.name)}
>
<Icon icon='mdi:delete-outline' />
</IconButton>
</Tooltip>
<IconButton
title='Details'
size='small'
sx={{ color: theme => theme.palette.text.secondary }}
onClick={() => handleShowDetails(row)}
>
<Icon icon='bx:show-alt' />
</IconButton>

<IconButton
title='Edit'
size='small'
sx={{ color: theme => theme.palette.text.secondary }}
onClick={() => handleShowEditDialog(row)}
>
<Icon icon='mdi:square-edit-outline' />
</IconButton>

<IconButton
title='Delete'
size='small'
sx={{ color: theme => theme.palette.error.light }}
onClick={() => handleDeleteMetalake(row.name)}
>
<Icon icon='mdi:delete-outline' />
</IconButton>
</>
)
}
Expand Down

0 comments on commit df2d622

Please sign in to comment.