Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Istio VirtualService is missing spec.http.directResponse.withStatus() #390

Open
xvzf opened this issue Feb 9, 2024 · 1 comment
Open

Comments

@xvzf
Copy link
Member

xvzf commented Feb 9, 2024

It seems there's a bug in the generation, skipping the modifier for altering status codes in the directResponse (ref). At first glance, the CRD looks correct though

@xvzf xvzf added the bug label Feb 9, 2024
@Duologic
Copy link
Member

Duologic commented Oct 11, 2024

This is probably cause because the status field is excluded, the code is probably too agressive here:

var propertiesWithoutModifiers = map[string]excludeType{
"apiVersion": excludeInRootOnly,
"status": excludeEverywhere,
}

@Duologic Duologic removed the bug label Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants