From 33cd7a7174dfa1a2dbc744c4dd41e1adb6ddcada Mon Sep 17 00:00:00 2001
From: Jason Morris <jasonmorris@fastmail.com>
Date: Wed, 10 Apr 2024 20:30:25 -0400
Subject: [PATCH] Featured view refactor

Almost straight out of phind. Needed some variable name tweaks.
---
 app/Views/featured.php | 68 +++++++++++++++++++++++++++++-------------
 1 file changed, 48 insertions(+), 20 deletions(-)

diff --git a/app/Views/featured.php b/app/Views/featured.php
index a8ce572..b1a0542 100644
--- a/app/Views/featured.php
+++ b/app/Views/featured.php
@@ -10,38 +10,66 @@
 echo $this->include('includes/header'); ?>
 
 <main id="content" class="floor" tabindex="-1">
-  <div class="wrap">
+ <div class="wrap">
     <h1>News</h1>
-  </div>
+ </div>
 
-  <div class="wrap">
-  <?php foreach ($build as $row) :?>
+ <div class="wrap">
+ <?php foreach ($build as $row) :?>
     <article class="box box--feature">
       <h2>
         <a href="/sites/<?= $row['site_slug']; ?>"><?= $row['site_name']; ?></a>
-        <span class="ago--muted"><?php
-        $time = Time::createFromFormat('Y-m-d H:i:s', $row['site_date_last_post'], 'America/New_York');
-      echo $time->humanize();
-      ?></span>
+        <span class="ago--muted"><?= humanizeTime($row['site_date_last_post'], 'America/New_York'); ?></span>
       </h2>
       <ol class="links">
       <?php for ($story = 1; $story < 4; $story++) :?>
-        <?php $story_num = 'story' . $story; ?>
-        <?php if (isset($row[$story_num])) :?>
-        <li><a href="<?= $row[$story_num]['story_permalink']; ?>" rel="noopener noreferrer" data-outgoing="<?= $row[$story_num]['story_hash']; ?>"><?= htmlspecialchars_decode($row[$story_num]['story_title'] ?? '');
-            if (htmlspecialchars_decode($row[$story_num]['story_title']) === '') {
-                echo '[missing title]';
-            } ?></a></li>
-        <?php endif; ?>
-        <?php if (! isset($row[$story_num]) && $story === 1) :?>
-        <li>No recent posts</li>
-        <?php endif; ?>
+        <?php $storyNum = 'story' . $story; ?>
+        <?= displayStory($row, $storyNum); ?>
       <?php endfor; ?>
       </ol>
     </article>
-  <?php endforeach; ?>
-  </div>
+ <?php endforeach; ?>
+ </div>
 
 </main>
 
 <?= $this->include('includes/footer');
+
+/**
+ * Humanize the time for a given date.
+ *
+ * @param string $date
+ * @param string $timezone
+ *
+ * @return string
+ */
+function humanizeTime($date, $timezone)
+{
+    $time = Time::createFromFormat('Y-m-d H:i:s', $date, $timezone);
+
+    return $time->humanize();
+}
+
+/**
+ * Display a story link if it exists, otherwise display a message.
+ *
+ * @param array  $row
+ * @param string $storyNum
+ *
+ * @return string
+ */
+function displayStory($row, $storyNum)
+{
+    if (isset($row[$storyNum])) {
+        $story = $row[$storyNum];
+        $title = htmlspecialchars_decode($story['story_title'] ?? '');
+        $title = $title === '' ? '[missing title]' : $title;
+
+        return "<li><a href=\"{$story['story_permalink']}\" rel=\"noopener noreferrer\" data-outgoing=\"{$story['story_hash']}\">{$title}</a></li>";
+    }
+    if ($storyNum === 'story1') {
+        return '<li>No recent posts</li>';
+    }
+
+    return '';
+}