Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ab/fix tests #1

Merged
merged 13 commits into from
Jan 31, 2025
Merged

Ab/fix tests #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
ff659b9
Fixed some warnings
abarciauskas-bgse Jan 30, 2025
b3ed8ff
Fixed codec test
abarciauskas-bgse Jan 30, 2025
57be796
Fix warnings in test_backend.py
abarciauskas-bgse Jan 30, 2025
deb15ba
Tests passing
abarciauskas-bgse Jan 31, 2025
cecc151
Remove obsolete comment
abarciauskas-bgse Jan 31, 2025
6d06291
Add fill value to fixture
abarciauskas-bgse Jan 31, 2025
4a2f294
Remove obsolete conditional to ds.close()
abarciauskas-bgse Jan 31, 2025
aa55a39
Reset workflows with --cov
abarciauskas-bgse Jan 31, 2025
83379ee
Reset conftest.py fixtures (air encoding)
abarciauskas-bgse Jan 31, 2025
7786421
Reset contributiong (--cov) removed
abarciauskas-bgse Jan 31, 2025
45eb86b
Remove context manager from readers/common.py
abarciauskas-bgse Jan 31, 2025
0babb65
Reset test_backend with ds.dims
abarciauskas-bgse Jan 31, 2025
dc4ed8b
Reset test_icechunk (air encoding)
abarciauskas-bgse Jan 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ci/upstream.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ channels:
- conda-forge
- nodefaults
dependencies:
- xarray>=2024.10.0,<2025.0.0
- xarray>=2025.1.1
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ This fixes the Group.create_array() got an unexpected keyword argument 'exists_ok' test failure

- h5netcdf
- h5py
- hdf5
Expand All @@ -29,6 +29,6 @@ dependencies:
- fsspec
- pip
- pip:
- icechunk==0.1.0a12 # Installs python-zarr v3 as dependency
- icechunk>=0.1.0a12 # Installs python-zarr v3 as dependency
- git+https://github.com/fsspec/kerchunk.git@main
- imagecodecs-numcodecs==2024.6.1
4 changes: 3 additions & 1 deletion virtualizarr/tests/test_codecs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,9 @@ def test_manifest_array_zarr_v2_normalized(self):

# Get codecs and verify
actual_codecs = get_codecs(manifest_array, normalize_to_zarr_v3=True)
expected_codecs = manifest_array.zarray._v3_codec_pipeline()
expected_codecs = (
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Fixes failing test

manifest_array.zarray.serializer(),
) + manifest_array.zarray._v3_codec_pipeline()
assert actual_codecs == expected_codecs

@requires_zarr_python_v3
Expand Down
2 changes: 1 addition & 1 deletion virtualizarr/tests/test_writers/test_zarr.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ def test_zarr_v3_metadata_conformance(tmpdir, vds_with_manifest_arrays: Dataset)
assert isinstance(metadata["fill_value"], (bool, int, float, str, list))
assert (
isinstance(metadata["codecs"], list)
and len(metadata["codecs"]) > 1
and len(metadata["codecs"]) == 1
Copy link
Author

@abarciauskas-bgse abarciauskas-bgse Jan 31, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Fixes failing test

and all(isconfigurable(codec) for codec in metadata["codecs"])
)

Expand Down