Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add zipfilename to title and overview #1444

Merged
merged 4 commits into from
Jan 12, 2024
Merged

add zipfilename to title and overview #1444

merged 4 commits into from
Jan 12, 2024
+21 −2

Conversation

Kr0nox
Copy link
Member

@Kr0nox Kr0nox commented Dec 13, 2023

The name of the uploaded zip gets displayed:

  • In the page title
  • On the overview view
  • On the information view

@Kr0nox Kr0nox added the report-viewer PR / Issue deals (partly) with the report viewer and thus involves web-dev technologies label Dec 13, 2023
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'JPlag Report Viewer'

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@tsaglam tsaglam added enhancement Issue/PR that involves features, improvements and other changes minor Minor issue/feature/contribution/change labels Dec 13, 2023
@Kr0nox Kr0nox changed the title add filename to store add zipfilename to title and overview Dec 14, 2023
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'JPlag Report Viewer'

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

sebinside
sebinside approved these changes Jan 12, 2024
View reviewed changes
Copy link
Member

@sebinside sebinside left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only made a small adjustment to better support smaller screens (or many open tabs :)).

@sebinside sebinside merged commit 256b149 into develop Jan 12, 2024
16 checks passed
@sebinside sebinside deleted the report-viewer/show-zip-name branch January 12, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebinside sebinside sebinside approved these changes

@tsaglam tsaglam Awaiting requested review from tsaglam

@TwoOfTwelve TwoOfTwelve Awaiting requested review from TwoOfTwelve

Assignees
No one assigned
Labels
enhancement Issue/PR that involves features, improvements and other changes minor Minor issue/feature/contribution/change report-viewer PR / Issue deals (partly) with the report viewer and thus involves web-dev technologies
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Kr0nox @sebinside @tsaglam