This repository has been archived by the owner on Sep 16, 2020. It is now read-only.
use erlang's queue data-structure for mantaining pending jobs, instead of list #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks good to me @joakimk |
|
Yep, it looks good. I don't have any way of verifying it myself, but it passes the tests and seems to make sense. I merged it and refactored the code a bit. Released as 1.0.6. |
|
Thanks @nimish-mehta for the contribution and thanks @benwilson512 for mentioning me, I seem to have missed the original notification about this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #17 queueing lots of job will be in-efficient using lists, We can use Erlang's queue data structure to maintain the pending jobs list more efficiently.