Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support region without brackets #5

Open
thammin opened this issue May 28, 2018 · 2 comments
Open

Support region without brackets #5

thammin opened this issue May 28, 2018 · 2 comments

Comments

@thammin
Copy link

thammin commented May 28, 2018

Hi, what an lovely extension!
It will be very handy if we can use it without the brackets.

Example Code:

#region SomeOldCodes

Example Settings:

"coloredRegions.namedColors": {
    "SomeOldCodes": "rgba(79, 44, 115, 0.5)"
}
@lonix1
Copy link

lonix1 commented Feb 13, 2019

This would play better with existing tools and vscode plugins, so +1

@Kasheftin
Copy link
Collaborator

In my opinion, using brackets for color customization is a nice and stable approach. In our project, we defined short color names like imports, main, hooks, etc. and we would not like if a region defined by #region kanban csv imports methods was colored in [imports] color because it has imports word in the comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants