Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adapt pull/8 to joomla 4+ #96

Merged
merged 7 commits into from
Dec 30, 2024
Merged

adapt pull/8 to joomla 4+ #96

merged 7 commits into from
Dec 30, 2024

Conversation

JLTRY
Copy link
Collaborator

@JLTRY JLTRY commented Dec 30, 2024

No need to adapt search plugin modifications
Only hide empty brackets is needed

	attachments_component/admin/config.xml
	attachments_component/site/tmpl/attachments/default.php
Copy link
Collaborator

@parapente parapente left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest we omit the $description all together as it contains a non breakable space that pushes the file size further to the right. I also changed the config option to appear with the new layout as a switch

attachments_component/admin/config.xml Outdated Show resolved Hide resolved
attachments_component/site/tmpl/attachments/default.php Outdated Show resolved Hide resolved
attachments_component/site/tmpl/attachments/default.php Outdated Show resolved Hide resolved
attachments_component/site/tmpl/attachments/default.php Outdated Show resolved Hide resolved
attachments_component/site/tmpl/attachments/default.php Outdated Show resolved Hide resolved
parapente and others added 6 commits December 30, 2024 15:42
Co-authored-by: Theofilos Intzoglou <int.teo@gmail.com>
Co-authored-by: Theofilos Intzoglou <int.teo@gmail.com>
Co-authored-by: Theofilos Intzoglou <int.teo@gmail.com>
Co-authored-by: Theofilos Intzoglou <int.teo@gmail.com>
Co-authored-by: Theofilos Intzoglou <int.teo@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants