Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New features introduced: hide empty brackets, alternative search result #8

Closed
wants to merge 6 commits into from

Conversation

yild
Copy link

@yild yild commented Jun 11, 2016

This fork introduce:

  1. Option to hide 'unnecessary' bracket chars [] when 'description' field and user defined fields are empty,
  2. Clickable search result titles that links to content to which attachment was attached, rather than to file/url itself, both article and/or category.

Both options are added to config.xml, default off.

ps. if i did everything correct this should work out of the box - i'm new to this github thing ;)

@yild
Copy link
Author

yild commented Sep 23, 2017

bump

@yild
Copy link
Author

yild commented Apr 24, 2018

bump @jmcameron

@yild yild force-pushed the master branch 3 times, most recently from 642997c to 3dc1b36 Compare February 7, 2023 23:01
yild and others added 2 commits February 8, 2023 00:07
@parapente
Copy link
Collaborator

@yild I am interested in adding the configuration option for hiding the empty brackets but I don't think it is worth it to add new code/options for the attachments_search plugin. This plugin depends on com_search which is now deprecated and com_finder should be used instead. Do you have the time to update the code so it merges with master with the necessary changes?

@JLTRY
Copy link
Collaborator

JLTRY commented Dec 30, 2024

The implementation for adavanced search was done for Joomla 3.0
The idea was to add a link to the article or the category associated with the attachment

  • Before modification

joomla 3 search

  • After modification

joomla 3 search new

  • The 2 First links are replaced by links to the article

  • For Joomla 4+ the links are already set to the article or category. No need to change something

joomla 4 finder

@parapente
Copy link
Collaborator

Closing as PR #96 was merged with the code for hiding the empty brackets. Thank you @yild

@parapente parapente closed this Dec 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants