Reload iframe content before closing the modal #48
+4
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@parapente it works , you can merge it |
|
ok @JLTRY thanks! Before you add your modifications I wanted to ask you about the check you added for restrict_uploads_extensions. I cannot find any resource for changing restrict_uploads_extensions to upload_extensions. Can you please link where you found this change? Even running grep on the source of Joomla 5 I cannot find any mentions of upload_extensions. It seems to be still restrict_uploads_extensions. It used to be upload_extensions in Joomla 2 & 3 I think. |
|
You can push the rest of the changes to master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Possible fix for #41. Can you test @JLTRY ?