New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed unhandled exception when cancel is called on the CancellationToken #6

Open

sam1308 wants to merge 1 commit into jjrdk:master from sam1308:master

sam1308 commented Mar 8, 2017

Hi, first of all great work!

Code to reproduce:

var cts = new CancellationTokenSource();
var websocket = new WebSocket("ws://1.2.3.4/dummy", cts.Token);

// After any moment in time
cts.Cancel(); // this causes an uncaught TaskCancelledException

Which led me to the async void lambda expression ;)


          Fixed unhandled exception when cancel is called on the CancellationToken

a694784

Xilconic commented Mar 5, 2018

Any update on this pull request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet