fix(web) fix generated config syntax #2038
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saghul
force-pushed
the
fix-es6-syntax
branch
2 times, most recently
from
8a93047 to
892b564
Compare
This is the version we evaluate config.js with on Android, making it the lowest common denominator. While being a nifty little engine, it suffers from not being fully ES6 compliant, so things like arrow functions or template strings are not implemented.
saghul
force-pushed
the
fix-es6-syntax
branch
from
892b564 to
b8a8f09
Compare
Arrow functions don't work on the JS interpreter which evaluates config.js on Android. Fixes: #2031
|
Example of previously failing: https://github.com/jitsi/docker-jitsi-meet/actions/runs/13595798766/job/38012303929 That was without the 2nd commit. Now config is tested through Duktape, not Node, like it runs on Android. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Arrow functions don't work on the JS interpreter which evaluates config.js on Android.