Add Env for Shared document random name #1985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daimoc
changed the title
Co-authored-by: Aaron van Meerten <aaron.van.meerten@gmail.com>
saghul
reviewed
Dec 21, 2024
saghul
approved these changes
Dec 23, 2024
|
Hi, just checking in on this PR. Let me know if anything is needed from my side to help with the validation. Thanks! |
|
Opsie, merged now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Since many years, Jicofo has a parameter to use a random name in Etherpad : https://github.com/jitsi/jicofo/blob/5803269e775b84aa53d18cade50e81c33a26cc47/jicofo-selector/src/main/resources/reference.conf#L223.
It makes the Etherpad link only known by conference participant and more secure.
This pull request adds this option in the docker version.