Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(web): include custom nginx conf files #1969

Merged
merged 1 commit into from
Jan 29, 2025

Conversation

emrahcom
Copy link
Contributor

PR adds an include line into Nginx config to allow custom configuration in it.

Like include /etc/jitsi/meet/jaas/*.conf line in jitsi-meet.example.

In my use-case, I will add my OIDC backend as proxy by creating a config file in this folder.
Not having this folder (/config/nginx-custom/) by default is not a problem for Nginx.

@atlashour
Copy link

If I modify that line myself at meet.conf, nothing happens when I run: docker compose up -d.

Why when you change something at rootfs it won't work in the docker container?

Need some help here, thank you so much for you contribution. I hope your feature will be integrated soon.

@saghul saghul merged commit 2a329fa into jitsi:master Jan 29, 2025
1 check passed
@emrahcom
Copy link
Contributor Author

If I modify that line myself at meet.conf, nothing happens when I run: docker compose up -d.

Why when you change something at rootfs it won't work in the docker container?

Hi @atlashour, this change has no effect if you don't have custom config files in /config/nginx-custom but if you want to inject some additional configs into Nginx then you may put them into this folder as files.

This type of customization is needed in some setups.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants