Sonar: Local-Variable Type Inference should be used

src/main/resources/generator/server/javatool/base/test/error/MissingMandatoryValueExceptionTest.java.mustache

@@ -12,23 +12,23 @@ class MissingMandatoryValueExceptionTest {
 
   @Test
   void shouldGetExceptionForBlankValue() {
-    MissingMandatoryValueException exception = MissingMandatoryValueException.forBlankValue(FIELD);
+    var exception = MissingMandatoryValueException.forBlankValue(FIELD);
 
     assertDefaultInformation(exception);
     assertThat(exception.getMessage()).isEqualTo("The field \"field\" is mandatory and wasn't set (blank)");
   }
 
   @Test
   void shouldGetExceptionForNullValue() {
-    MissingMandatoryValueException exception = MissingMandatoryValueException.forNullValue(FIELD);
+    var exception = MissingMandatoryValueException.forNullValue(FIELD);
 
     assertDefaultInformation(exception);
     assertThat(exception.getMessage()).isEqualTo("The field \"field\" is mandatory and wasn't set (null)");
   }
 
   @Test
   void shouldGetExceptionForEmptyCollection() {
-    MissingMandatoryValueException exception = MissingMandatoryValueException.forEmptyValue(FIELD);
+    var exception = MissingMandatoryValueException.forEmptyValue(FIELD);
 
     assertDefaultInformation(exception);
     assertThat(exception.getMessage()).isEqualTo("The field \"field\" is mandatory and wasn't set (empty)");

src/main/resources/generator/server/javatool/base/test/error/NullElementInCollectionExceptionTest.java.mustache

@@ -10,7 +10,7 @@ class NullElementInCollectionExceptionTest {
 
   @Test
   void shouldGetExceptionInformation() {
-    NullElementInCollectionException exception = new NullElementInCollectionException("myField");
+    var exception = new NullElementInCollectionException("myField");
 
     assertThat(exception.type()).isEqualTo(AssertionErrorType.NULL_ELEMENT_IN_COLLECTION);
     assertThat(exception.field()).isEqualTo("myField");

src/main/resources/generator/server/pagination/domain/test/AppPageableTest.java.mustache

@@ -33,7 +33,7 @@ class {{baseName}}PageableTest {
 
   @Test
   void shouldGetFirstPageInformation() {
-    {{baseName}}Pageable pageable = new {{baseName}}Pageable(0, 15);
+    var pageable = new {{baseName}}Pageable(0, 15);
 
     assertThat(pageable.page()).isZero();
     assertThat(pageable.pageSize()).isEqualTo(15);
@@ -42,7 +42,7 @@ class {{baseName}}PageableTest {
 
   @Test
   void shouldGetPageableInformation() {
-    {{baseName}}Pageable pageable = new {{baseName}}Pageable(2, 15);
+    var pageable = new {{baseName}}Pageable(2, 15);
 
     assertThat(pageable.page()).isEqualTo(2);
     assertThat(pageable.pageSize()).isEqualTo(15);

src/main/resources/generator/server/springboot/dbmigration/liquibase/main/SpringLiquibaseUtil.java.mustache

@@ -68,7 +68,7 @@ final class SpringLiquibaseUtil {
     DataSource dataSource,
     DataSourceProperties dataSourceProperties
   ) {
-    AsyncSpringLiquibase liquibase = new AsyncSpringLiquibase(executor, env, liquibaseProperties);
+    var liquibase = new AsyncSpringLiquibase(executor, env, liquibaseProperties);
     var liquibaseDataSource = getDataSource(liquibaseDatasource, liquibaseProperties, dataSource);
     if (liquibaseDataSource != null) {
       liquibase.setCloseDataSourceOnceMigrated(false);

src/main/resources/generator/server/springboot/dbmigration/liquibase/test/LiquibaseConfigurationIT.java.mustache

@@ -21,7 +21,7 @@ class LiquibaseConfigurationIT {
 
     @Test
     void shouldGetLiquibaseAsync() {
-      SpringLiquibase springLiquibase = (SpringLiquibase) applicationContext.getBean("liquibase");
+      var springLiquibase = (SpringLiquibase) applicationContext.getBean("liquibase");
 
       assertThat(springLiquibase).isNotNull();
     }
@@ -36,7 +36,7 @@ class LiquibaseConfigurationIT {
 
     @Test
     void shouldGetLiquibaseSync() {
-      SpringLiquibase springLiquibase = (SpringLiquibase) applicationContext.getBean("liquibase");
+      var springLiquibase = (SpringLiquibase) applicationContext.getBean("liquibase");
 
       assertThat(springLiquibase).isNotNull();
     }

src/main/resources/generator/server/springboot/logging/logstash/test/LogstashTcpConfigurationIT.java.mustache

@@ -49,7 +49,7 @@ class LogstashTcpConfigurationIT {
 
       assertThat(appender).isInstanceOf(LogstashTcpSocketAppender.class);
 
-      LogstashTcpSocketAppender logstashTcpSocketAppender = (LogstashTcpSocketAppender) appender;
+      var logstashTcpSocketAppender = (LogstashTcpSocketAppender) appender;
 
       assertThat(logstashTcpSocketAppender.getDestinations()).contains(new InetSocketAddress("127.0.0.1", 50000));
       assertThat(logstashTcpSocketAppender.getRingBufferSize()).isEqualTo(4096);

src/main/resources/generator/server/springboot/logging/logstash/test/LogstashTcpConfigurationTest.java.mustache

@@ -20,7 +20,7 @@ class LogstashTcpConfigurationTest {
 
   @Test
   void shouldAddAppNameOnly() throws IOException {
-    LogstashTcpConfiguration c = new LogstashTcpConfiguration("jhipster-lite", null, new LogstashTcpProperties());
+    var c = new LogstashTcpConfiguration("jhipster-lite", null, new LogstashTcpProperties());
 
     ObjectContent<Map<String, String>> parsed = json.parse(c.logstashTcpLifeCycle().serializedFields());
     assertThat(parsed.getObject()).hasSize(1);

src/main/resources/generator/server/springboot/mvc/sample/feature/main/domain/beer/BeersCreator.java.mustache

@@ -13,7 +13,7 @@ public class BeersCreator {
   }
 
   public Beer create(BeerToCreate beerToCreate) {
-    Beer createdBeer = beerToCreate.create();
+    var createdBeer = beerToCreate.create();
 
     beers.save(createdBeer);
 

src/main/resources/generator/server/springboot/mvc/sample/feature/main/infrastructure/primary/beer/BeersResource.java.mustache

@@ -16,7 +16,6 @@ import org.springframework.web.bind.annotation.RequestMapping;
 import org.springframework.web.bind.annotation.RestController;
 import {{packageName}}.sample.application.BeersApplicationService;
 import {{packageName}}.sample.domain.BeerId;
-import {{packageName}}.sample.domain.beer.Beer;
 
 @RestController
 @Tag(name = "Beers")
@@ -33,7 +32,7 @@ class BeersResource {
   @Operation(summary = "Add a beer to the catalog")
   @ApiResponse(description = "Beer added to the catalog", responseCode = "201")
   ResponseEntity<RestBeer> addBeer(@Validated @RequestBody RestBeerToCreate beerToCreate) {
-    Beer createdBeer = beers.create(beerToCreate.toDomain());
+    var createdBeer = beers.create(beerToCreate.toDomain());
 
     return new ResponseEntity<>(RestBeer.from(createdBeer), HttpStatus.CREATED);
   }

src/main/resources/generator/server/springboot/mvc/sample/feature/test/sample/domain/beer/BeersTest.java.mustache

@@ -20,7 +20,7 @@ class BeersTest {
       .sellingState(BeerSellingState.SOLD)
       .build();
 
-    Beers beers = new Beers(List.of(beer(), anteMeridiem));
+    var beers = new Beers(List.of(beer(), anteMeridiem));
 
     assertThat(beers.get()).usingRecursiveFieldByFieldElementComparator().containsExactly(anteMeridiem, beer());
   }

src/main/resources/generator/server/springboot/mvc/security/jwt/authentication/main/infrastructure/primary/JWTConfigurer.java.mustache

@@ -15,7 +15,7 @@ class JWTConfigurer extends SecurityConfigurerAdapter<DefaultSecurityFilterChain
 
   @Override
   public void configure(HttpSecurity http) {
-    JWTFilter jwtFilter = new JWTFilter(jwt);
+    var jwtFilter = new JWTFilter(jwt);
 
     http.addFilterBefore(jwtFilter, UsernamePasswordAuthenticationFilter.class);
   }

src/main/resources/generator/server/springboot/mvc/security/jwt/authentication/main/infrastructure/primary/SecurityConfiguration.java.mustache

@@ -89,7 +89,7 @@ class SecurityConfiguration {
         .anyRequest().authenticated()
       );
 
-      JWTConfigurer jwtConfigurer = new JWTConfigurer(authenticationTokenReader());
+      var jwtConfigurer = new JWTConfigurer(authenticationTokenReader());
       http.with(jwtConfigurer, Customizer.withDefaults());
       return http.build();
     // @formatter:on

src/main/resources/generator/server/springboot/mvc/security/jwt/authentication/test/infrastructure/primary/JwtReaderTest.java.mustache

@@ -13,7 +13,6 @@ import javax.crypto.SecretKey;
 import org.junit.jupiter.api.Test;
 import org.junit.jupiter.api.extension.ExtendWith;
 import org.mockito.junit.jupiter.MockitoExtension;
-import org.springframework.security.core.Authentication;
 import org.springframework.security.core.authority.SimpleGrantedAuthority;
 import org.springframework.security.core.userdetails.User;
 import {{packageName}}.Logs;
@@ -58,7 +57,7 @@ class JwtReaderTest {
 
   @Test
   void shouldGetAuthenticationFromValidToken() {
-    Authentication authentication = reader.read(userToken()).orElseThrow();
+    var authentication = reader.read(userToken()).orElseThrow();
 
     assertThat(((User) authentication.getPrincipal()).getUsername()).isEqualTo("test");
     assertThat(authentication.getAuthorities().stream().map(SimpleGrantedAuthority.class::cast)).containsExactly(
@@ -78,7 +77,7 @@ class JwtReaderTest {
 
   @Test
   void shouldGetAuthenticationFromValidTokenWithoutRoles() {
-    Authentication authentication = reader.read(userTokenWithoutRoles()).orElseThrow();
+    var authentication = reader.read(userTokenWithoutRoles()).orElseThrow();
 
     assertThat(((User) authentication.getPrincipal()).getUsername()).isEqualTo("test");
     assertThat(authentication.getAuthorities()).isEmpty();

src/main/resources/generator/server/springboot/mvc/security/jwt/basic-auth/main/infrastructure/primary/AuthenticationResource.java.mustache

@@ -11,7 +11,6 @@ import org.springframework.web.bind.annotation.PostMapping;
 import org.springframework.web.bind.annotation.RequestBody;
 import org.springframework.web.bind.annotation.RequestMapping;
 import org.springframework.web.bind.annotation.RestController;
-import {{packageName}}.account.domain.Token;
 
 @RestController
 @RequestMapping("/api/authenticate")
@@ -32,7 +31,7 @@ class AuthenticationResource {
   @PostMapping
   @Operation(description = "Build an authentication token for the user")
   public ResponseEntity<RestToken> authorize(@Valid @RequestBody RestAuthenticationQuery authenticationQuery) {
-    Token token = authenticator.authenticate(authenticationQuery);
+    var token = authenticator.authenticate(authenticationQuery);
 
     var httpHeaders = new HttpHeaders();
     httpHeaders.add(HttpHeaders.AUTHORIZATION, token.bearer());

src/main/resources/generator/server/springboot/mvc/security/jwt/basic-auth/main/infrastructure/primary/Authenticator.java.mustache

@@ -1,7 +1,6 @@
 package {{packageName}}.account.infrastructure.primary;
 
 import org.springframework.security.config.annotation.authentication.builders.AuthenticationManagerBuilder;
-import org.springframework.security.core.Authentication;
 import org.springframework.security.core.context.SecurityContextHolder;
 import org.springframework.stereotype.Service;
 import {{packageName}}.account.application.AccountApplicationService;
@@ -20,7 +19,7 @@ class Authenticator {
   }
 
   Token authenticate(RestAuthenticationQuery query) {
-    Authentication authentication = authenticationManagerBuilder.getObject().authenticate(query.authenticationToken());
+    var authentication = authenticationManagerBuilder.getObject().authenticate(query.authenticationToken());
 
     SecurityContextHolder.getContext().setAuthentication(authentication);
 

src/main/resources/generator/server/springboot/mvc/security/kipe/authorization/main/RolesAccesses.java.mustache

@@ -38,7 +38,7 @@ public final class RolesAccesses {
 
   private Predicate<Role> allAuthorized(Action action, Resource resource) {
     return role -> {
-      Accesses accesses = roles.get(role);
+      var accesses = roles.get(role);
 
       if (accesses == null) {
         return false;
@@ -58,7 +58,7 @@ public final class RolesAccesses {
 
   private Predicate<Role> specificAuthorized(Action action, Resource resource) {
     return role -> {
-      Accesses accesses = roles.get(role);
+      var accesses = roles.get(role);
 
       if (accesses == null) {
         return false;

src/main/resources/generator/server/springboot/mvc/security/kipe/expression/main/KipeMethodSecurityExpressionHandler.java.mustache

@@ -23,7 +23,7 @@ class KipeMethodSecurityExpressionHandler extends DefaultMethodSecurityExpressio
   public EvaluationContext createEvaluationContext(Supplier<Authentication> authentication, MethodInvocation mi) {
     MethodSecurityExpressionOperations root = buildExpressionRoot(authentication, mi);
 
-    MethodBasedEvaluationContext ctx = new MethodBasedEvaluationContext(
+    var ctx = new MethodBasedEvaluationContext(
       root,
       getSpecificMethod(mi),
       mi.getArguments(),
@@ -40,7 +40,7 @@ class KipeMethodSecurityExpressionHandler extends DefaultMethodSecurityExpressio
   }
 
   private MethodSecurityExpressionOperations buildExpressionRoot(Supplier<Authentication> authentication, MethodInvocation invocation) {
-    KipeMethodSecurityExpressionRoot root = new KipeMethodSecurityExpressionRoot(authentication, evaluator);
+    var root = new KipeMethodSecurityExpressionRoot(authentication, evaluator);
 
     root.setThis(invocation.getThis());
     root.setPermissionEvaluator(getPermissionEvaluator());

src/main/resources/generator/server/springboot/mvc/security/kipe/expression/test/AccessEvaluatorTest.java.mustache

@@ -34,7 +34,7 @@ class AccessEvaluatorTest {
 
   @Test
   void shouldResolveOnDefaultCheckerForNullObject() {
-    AccessEvaluator canEvaluator = new AccessEvaluator(List.of(new ObjectAccessChecker()));
+    var canEvaluator = new AccessEvaluator(List.of(new ObjectAccessChecker()));
 
     boolean can = canEvaluator.can(authentication, "action", null);
 
@@ -44,7 +44,7 @@ class AccessEvaluatorTest {
 
   @Test
   void shouldResolveOnDefaultCheckerForUnknownType() {
-    AccessEvaluator canEvaluator = new AccessEvaluator(List.of(new ObjectAccessChecker()));
+    var canEvaluator = new AccessEvaluator(List.of(new ObjectAccessChecker()));
 
     boolean can = canEvaluator.can(authentication, "action", "yo");
 
@@ -54,14 +54,14 @@ class AccessEvaluatorTest {
 
   @Test
   void shouldGetMatchingEvaluator() {
-    AccessEvaluator canEvaluator = new AccessEvaluator(List.of(new ObjectAccessChecker(), new KipeDummyAccessChecker()));
+    var canEvaluator = new AccessEvaluator(List.of(new ObjectAccessChecker(), new KipeDummyAccessChecker()));
 
     assertThat(canEvaluator.can(authentication, "action", new KipeDummy("authorized"))).isTrue();
   }
 
   @Test
   void shouldGetMatchingEvaluatorForChildClass() {
-    AccessEvaluator canEvaluator = new AccessEvaluator(List.of(new ObjectAccessChecker(), new KipeDummyAccessChecker()));
+    var canEvaluator = new AccessEvaluator(List.of(new ObjectAccessChecker(), new KipeDummyAccessChecker()));
 
     assertThat(canEvaluator.can(authentication, "action", new KipeDummyChild("authorized"))).isTrue();
     logs.shouldHave(Level.INFO, "evaluator", 1);

src/test/java/tech/jhipster/lite/shared/error/domain/MissingMandatoryValueExceptionTest.java

@@ -12,21 +12,21 @@ class MissingMandatoryValueExceptionTest {
 
   @Test
   void shouldGetExceptionForBlankValue() {
-    MissingMandatoryValueException exception = MissingMandatoryValueException.forBlankValue(FIELD);
+    var exception = MissingMandatoryValueException.forBlankValue(FIELD);
 
     assertThat(exception.getMessage()).isEqualTo("The field \"field\" is mandatory and wasn't set (blank)");
   }
 
   @Test
   void shouldGetExceptionForNullValue() {
-    MissingMandatoryValueException exception = MissingMandatoryValueException.forNullValue(FIELD);
+    var exception = MissingMandatoryValueException.forNullValue(FIELD);
 
     assertThat(exception.getMessage()).isEqualTo("The field \"field\" is mandatory and wasn't set (null)");
   }
 
   @Test
   void shouldGetExceptionForEmptyCollection() {
-    MissingMandatoryValueException exception = MissingMandatoryValueException.forEmptyValue(FIELD);
+    var exception = MissingMandatoryValueException.forEmptyValue(FIELD);
 
     assertThat(exception.getMessage()).isEqualTo("The field \"field\" is mandatory and wasn't set (empty)");
   }