[React] Fix bump browser-sync from 2.29.3 to 3.0.3 #28575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
theme: react
theme: dependencies
|
@mshima any idea? locally it works 🤔 |
|
Package.json overrides only works at workspaces root: |
mshima
reviewed
Feb 5, 2025
generators/react/generator.ts
Outdated
Comment on lines
121
to
128
| if (application.clientRootDir) { | ||
| // Overrides only works if added in root package.json | ||
| this.packageJson.merge({ | ||
| overrides: { | ||
| 'browser-sync': application.nodeDependencies['browser-sync'], | ||
| }, | ||
| }); | ||
| } |
There was a problem hiding this comment.
Needs to be run in postWriting otherwise the modified package.json will be overridden in writing priority.
mshima
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #28571
https://www.npmjs.com/package/browser-sync-webpack-plugin no longer appears to be maintained
Please make sure the below checklist is followed for Pull Requests.
When you are still working on the PR, consider converting it to Draft (below reviewers) and adding
skip-cilabel, you can still see CI build result at your branch.