Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix - Conan detection on projects with conanfile.py #391

Merged
merged 2 commits into from
Mar 18, 2025

Conversation

attiasas
Copy link
Contributor

  • The pull request is targeting the dev branch.
  • The code has been validated to compile successfully by running go vet ./....
  • The code has been formatted properly using go fmt ./....
  • All static analysis checks passed.
  • All tests have passed. If this feature is not already covered by the tests, new tests have been added.
  • Updated the Contributing page / ReadMe page / CI Workflow files if needed.
  • All changes are detailed at the description. if not already covered at JFrog Documentation, new documentation have been added.

there was an extra space at the Conan indicator, preventing detection on projects with conanfile.py

@attiasas attiasas added bug Something isn't working safe to test Approve running integration tests on a pull request labels Mar 12, 2025
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Mar 12, 2025
@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Mar 12, 2025
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Mar 12, 2025
Copy link

👍 Frogbot scanned this pull request and did not find any new security issues.


@attiasas attiasas requested review from dortam888, eranturgeman, orz25, hadarshjfrog and orto17 and removed request for dortam888 March 12, 2025 11:47
@attiasas attiasas merged commit c8537dd into jfrog:dev Mar 18, 2025
57 of 59 checks passed
@attiasas attiasas deleted the fix_conan_detection branch March 18, 2025 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants