Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restricting usage in ConfigProfile with Xray version prior to 3.117.0 #834

Open
wants to merge 6 commits into
base: dev
Choose a base branch
from

Conversation

eranturgeman
Copy link
Contributor

@eranturgeman eranturgeman commented Mar 10, 2025

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.
  • Update documentation about new features / new supported technologies

This PR introduces a new limitation for utilizing Config Profile - Xray version must be 3.117 or above.
If Xray version is lower than 3.117 and you wish to utilize config profile with the new abilities introduced here jfrog/jfrog-cli-security#314 you can either upgrade Xray or use prior Frogbot version until Xray version is upgraded.

Note: This restriction is valid ONLY when utilizing Config Profile. Other capabilities are not changed or blocked due to this restriction

@eranturgeman eranturgeman changed the title . Restricting usage in ConfigProfile with Xray version prior to 3.117.0 Mar 10, 2025
@eranturgeman eranturgeman added improvement Automatically generated release notes safe to test Approve running integration tests on a pull request labels Mar 10, 2025
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Mar 10, 2025
@eranturgeman eranturgeman requested a review from attiasas March 10, 2025 13:52
@eranturgeman eranturgeman added the safe to test Approve running integration tests on a pull request label Mar 10, 2025
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Mar 10, 2025
Copy link
Contributor

@attiasas attiasas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

👍 Frogbot scanned this pull request and did not find any new security issues.


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Automatically generated release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants