Closes #53: Add support for empty HTTP query param #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When query param is empty, use `jetzig.data.Data.NullType` - this way the value is still non-null (i.e. can be captured) and is still a `jetzig.data.Value` so is consistent with previous implementation. Add very weird bugfix for 404 responses. Fix `Bad Request` response code.
bobf
force-pushed
the
empty-http-params
branch
8 times, most recently
from
c5bc3e3 to
4579d6c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When query param is empty, use
jetzig.data.Data.NullType- this way the value is still non-null (i.e. can be captured) and is still ajetzig.data.Valueso is consistent with previous implementation.Add very weird bugfix for 404 responses.
Fix
Bad Requestresponse code.