New custom print function to handle windows unicode #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bobf
requested changes
Nov 30, 2024
| @@ -0,0 +1,41 @@ | |||
| const std = @import("std"); | |||
There was a problem hiding this comment.
I think this belongs in cli/util.zig - we already import this in cli/commands/init.zig.
| original: if (builtin.os.tag == .windows) c_uint else void, | ||
|
|
||
| fn init() !UTF8ConsoleOutput { | ||
| if (builtin.os.tag == .windows) { |
There was a problem hiding this comment.
If you flip this around you can use a guard clause to remove some indentation:
if (builtin.os.tag != .windows) return .{ .original = {} };
// ... windows logic
bobf
approved these changes
Nov 30, 2024
|
@z1fire Ready to merge - thanks a lot, Windows users deserve icons too. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The custom print function checks if on windows and if so it changes the way the terminal behaves just for that print function else just prints as normal