Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Maintainer wanted #23

Closed
jethrogb opened this issue Mar 9, 2020 · 4 comments
Closed

Maintainer wanted #23

jethrogb opened this issue Mar 9, 2020 · 4 comments
Labels
help wanted

Comments

@jethrogb
Copy link
Owner

jethrogb commented Mar 9, 2020

I'm currently reviewing PRs on a best-effort basis, which may take a month or so. If someone is willing to co-maintain this, that'd be great.
@jethrogb jethrogb pinned this issue Mar 9, 2020
@jrmuizel
Copy link
Collaborator

jrmuizel commented Mar 9, 2020

I'd be willing to co-maintain. We depend on this transitively through https://github.com/rust-lang/rust-bindgen so I don't want to see it abandoned.

@emilio
Copy link
Collaborator

emilio commented Mar 11, 2020

I'm happy to help out too, for the same reason. Not sure I can do active development, but I should've time for reviews and so on :)

@jyn514 jyn514 mentioned this issue Apr 10, 2020
Closed
@tweksteen tweksteen mentioned this issue May 12, 2021
Merged
bors bot added a commit that referenced this issue Jun 7, 2021
@bors @tweksteen
Merge #27
0eafea2 
27: Update to nom 6.x r=emilio a=tweksteen

This is an upgrade to nom 6.x. It was tested via `cargo test`. @jethrogb Could you please review? Could you please also consider adding @emilio as maintainer (see #23)? Thanks.

Old obsolete message:
> This is an attempt at upgrading to nom 6.x. There is still an issue in `typed_token` about the expected lifetime of the input. @jonhoo, since you did the port to nom 5.x, you may have some insight on how to fix this.
@jethrogb, any feedback is appreciated. Thanks.

Bug: #26

Co-authored-by: Thiébaud Weksteen <tweek@google.com>
@nox
Copy link

nox commented Sep 24, 2021

@jethrogb Do you still need comaintainers?

@jethrogb
Copy link
Owner Author

Both @jrmuizel and @emilio were added as co-maintainers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@nox @jrmuizel @jethrogb @emilio