Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ESC doesn't close the modal. #2

Open
stolemotion opened this issue Apr 27, 2017 · 2 comments
Open

ESC doesn't close the modal. #2

stolemotion opened this issue Apr 27, 2017 · 2 comments

Comments

@stolemotion
Copy link

As a desktop user I'd expect ESC to close the modal.
@jessekorzan
Copy link
Owner

That'd be an easy one for someone to tackle with a little JS, if they wanted. Personally, I don't believe it's a common expectation for web apps, but such a low effort addition that I can't see why not. And good test... I'd love to be proven wrong here.

I am also going to start trying ESC on different web apps.

@etse
Copy link

etse commented Jan 30, 2018

Adding ESC to close and sound (from #1) should make it mostly UU-compliant. Making it work for blind people.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@stolemotion @jessekorzan @etse