Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: specify details elements not found in debug message #360

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

giraffesyo
Copy link

Currently running the command prints "Found 0 Elements" on all pages that don't have a details element. This initially misled me to believe the tool wasn't working. This PR simply makes that logging a little more specific.

Original

[21.12.2023 13:57.48.821] [LOG] Retrieving html from https://parallelworks.com/docs/
[21.12.2023 13:57.49.823] [DEBUG] Found 0 elements
[21.12.2023 13:57.49.824] [LOG] Success

New

[21.12.2023 14:07.51.459] [LOG] Retrieving html from https://parallelworks.com/docs/
[21.12.2023 14:07.53.476] [DEBUG] Found 0 elements of type details
[21.12.2023 14:07.53.478] [LOG] Success

Copy link

codecov bot commented Dec 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e602d41) 95.32% compared to head (2e53897) 95.32%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #360   +/-   ##
=======================================
  Coverage   95.32%   95.32%           
=======================================
  Files           4        4           
  Lines         792      792           
  Branches       35       35           
=======================================
  Hits          755      755           
  Misses         37       37           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jean-humann
Copy link
Owner

LGTM @giraffesyo thanks for your contribution !

Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants