Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Precision Attack dice roll #7

Open
YenBenGrey opened this issue Feb 26, 2023 · 6 comments
Open

Precision Attack dice roll #7

YenBenGrey opened this issue Feb 26, 2023 · 6 comments

Comments

@YenBenGrey
Copy link

With Precision Attack the description states that you can make a decision before or after the roll of the D20.

The window that pops up does not tell you the result of the D20, the player needs to keep an eye on the dice.

It isn't a major problem however just thought I would mention it. Unless there is something in maybe Midi I can tweak so they can see the number after the roll? In the pop up window.

@BalrogTaco
Copy link

I have a modified version that shows the roll. But it also has a few other changes, so it may or may not work for you. Change the attached file to .json to import it if you would like to try it out
fvtt-Item-maneuvers_-precision-attack.txt

@YenBenGrey
Copy link
Author

What I’ve done for now is set the time it takes for Dice so Nice to hide the dice for that one player to about 6 seconds. So they shouldn’t miss it. However I will give this a go. Thank you.

@YenBenGrey
Copy link
Author

So far the above is amazing.

Is it supposed to not pop up if the attack hits, because that is brilliant. And it says if the attack will MISS. One of the concerns from the player is that it pops up when not needed.

@jbowensii
Copy link
Owner

thank you [BalrogTaco] I will incorporate your changes this week and give you credit. :)

@BalrogTaco
Copy link

@YenBenGrey yes it is supposed to not show the dialog if you hit or if you are out of superiority dice (as tracked as a resource, not as another feat as some importers set up the resource)

@jbowensii hope it helps. I think I have a few others of yours that I worked on as well, I suppose i should have made a PR

@jbowensii
Copy link
Owner

please send them over I will adjust and list you in the credits on the code and for the module..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants