From c9916c7e2610d2a4f4749b93e02c5308243cc166 Mon Sep 17 00:00:00 2001 From: Imran Iqbal Date: Mon, 7 May 2018 17:55:43 +0100 Subject: [PATCH] Improve consistency of reset value handling for `date` * Consistent implementation re: `datetime` * Consistent reset using `DATE_INPUT_FORMAT`, i.e. - Works whether `USE_L10N` setting is active or not --- constance/static/admin/js/constance.js | 3 +++ constance/templates/admin/constance/includes/results_list.html | 3 ++- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/constance/static/admin/js/constance.js b/constance/static/admin/js/constance.js index a67a160f..690dfcca 100644 --- a/constance/static/admin/js/constance.js +++ b/constance/static/admin/js/constance.js @@ -11,6 +11,9 @@ if (fieldType === 'checkbox') { field.prop('checked', this.dataset.default === 'true'); + } else if (fieldType === 'date') { + var defaultDate = new Date(this.dataset.default * 1000); + $('#' + this.dataset.fieldId).val(defaultDate.strftime(get_format('DATE_INPUT_FORMATS')[0]));} } else if (fieldType === 'datetime') { var defaultDate = new Date(this.dataset.default * 1000); $('#' + this.dataset.fieldId + '_0').val(defaultDate.strftime(get_format('DATE_INPUT_FORMATS')[0])); diff --git a/constance/templates/admin/constance/includes/results_list.html b/constance/templates/admin/constance/includes/results_list.html index 040dbe58..295388be 100644 --- a/constance/templates/admin/constance/includes/results_list.html +++ b/constance/templates/admin/constance/includes/results_list.html @@ -25,13 +25,14 @@ data-field-id="{{ item.form_field.auto_id }}" data-field-type="{% spaceless %} {% if item.is_checkbox %}checkbox + {% elif item.is_date %}date {% elif item.is_datetime %}datetime {% endif %} {% endspaceless %}" data-default="{% spaceless %} {% if item.is_checkbox %}{% if item.raw_default %} true {% else %} false {% endif %} + {% elif item.is_date %}{{ item.raw_default|date:"U" }} {% elif item.is_datetime %}{{ item.raw_default|date:"U" }} - {% elif item.is_date %}{{ item.raw_default.isoformat }} {% else %}{{ item.default }} {% endif %} {% endspaceless %}">{% trans "Reset to default" %}