Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade dependencies #205

Merged
merged 11 commits into from
Feb 9, 2025
Merged

Upgrade dependencies #205

merged 11 commits into from
Feb 9, 2025

Conversation

jannis-baum
Copy link
Owner

Close #204

@jannis-baum jannis-baum requested a review from tuurep February 9, 2025 15:42
@jannis-baum jannis-baum force-pushed the issue/204-upgrade-dependencies branch from 1883d8c to 3796aaf Compare February 9, 2025 15:50
@tuurep
Copy link
Collaborator

tuurep commented Feb 9, 2025

Yes looks like everything's OK, just made sure everything in tests/rendering/*.md still works.

I think it can be merged unless something needs special attention.

@tuurep
Copy link
Collaborator

tuurep commented Feb 9, 2025

upgrading-dependencies.md

This is great, I could reproduce it on Arch and I can see how doing this without this memo is a pain each time.

Some problems with yarn-deduplicate:

  1. Isn't a global npm/yarn install a bad practice?
  • though I'm mostly thinking about the python pip equivalent
  • Could we have like local dev dependencies with yarn-deduplicate and anything in the future we might need?
  1. If installed with yarn global add, the bin goes to ~/.yarn/bin on my machine which isn't on the $PATH by default
  • apparently yarn bin can be in a number of different places, but you can get your path with yarn global bin
  • if we could install yarn-deduplicate locally, this would be a non-issue

@jannis-baum
Copy link
Owner Author

Nice, very good idea! I made the adjustment. Can you confirm it works?

@tuurep
Copy link
Collaborator

tuurep commented Feb 9, 2025

Works, thanks!

@jannis-baum jannis-baum merged commit 668de49 into main Feb 9, 2025
6 checks passed
@jannis-baum jannis-baum deleted the issue/204-upgrade-dependencies branch February 9, 2025 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade dependencies
2 participants