Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support .config directory #180

Merged
merged 3 commits into from
Sep 5, 2024
Merged

Conversation

jannis-baum
Copy link
Owner

Close #179

@jannis-baum jannis-baum requested a review from tuurep September 5, 2024 00:57
@tuurep

This comment was marked as outdated.

@tuurep
Copy link
Collaborator

tuurep commented Sep 5, 2024

Darn it. The classic "I have an AUR package installed and didn't realize" -case. Let me try again 😄

@tuurep
Copy link
Collaborator

tuurep commented Sep 5, 2024

Alright I gave it a good try with each supported path and works great + I like the flexibility of it

The only thing is that if I have an empty config.json for example in the ~/.config/vivify/ path, I'd expect it to act as a 'default config' but when I have a ~/.vivify/config.json at the same time, that gets applied instead

What do you think about that?

@jannis-baum
Copy link
Owner Author

Currently, the first path that has a valid JSON object will be used. An empty file is not valid JSON. We can change it to try using the first path with a file no matter what. Do you think that's better?

@tuurep
Copy link
Collaborator

tuurep commented Sep 5, 2024

Hmm. Well, that would match my expectation of what should happen, but is that a small and easy change?

@jannis-baum
Copy link
Owner Author

Hmm. Well, that would match my expectation of what should happen, but is that a small and easy change?

Yes haha: bc70a8c. Can you verify that it works how you would expect now?

Copy link
Collaborator

@tuurep tuurep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lol it's the smallest change of all time 🎉

Yes I think it's quite perfect now, thanks!

@jannis-baum jannis-baum merged commit b665180 into main Sep 5, 2024
6 checks passed
@jannis-baum jannis-baum deleted the issue/179-support-config-directory branch September 5, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support .config directory
2 participants