Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Viv hanging on "Launching server..." #92

Closed
Tweekism opened this issue Jul 15, 2024 · 5 comments
Closed

Viv hanging on "Launching server..." #92

Tweekism opened this issue Jul 15, 2024 · 5 comments
Labels
type:bug Something isn't working

Comments

@Tweekism
Copy link
Collaborator

Hey guys,

Anyone seen this? viv hanging on "Launching server..." on the latest commit. Reverting to 09e4264 (Merge pull request #70) launches normally.

To Reproduce

  1. Built using latest commit on main 26421fa
  2. launch viv

Screenshots

image

Additional context

This is my work PC, a different PC to what I've been using over the weekend, so maybe I missed something? Running Fedora 40, same as home.

@Tweekism Tweekism added the type:bug Something isn't working label Jul 15, 2024
@jannis-baum
Copy link
Owner

Hello!

This version works for Tuure and me so let's see.

  • What build is this, did you build yourself or did you download from the CI?
  • If you built yourself, did you run yarn before building? Lots of packages were updated so this is necessary.
  • If you did run yarn or use the CI build: What output do you get by just running vivify-server manually?
  • And finally, if you built yourself, could you try the CI build or the other way around?

@Tweekism
Copy link
Collaborator Author

Ok, I don't know what to tell ya. I was able to replicate this issue several times this morning bouncing between 26421fa - current main and 09e4264 - Merge #70, but now I can't.

My current hypothesis is maybe there was some left over files from when I tried to build it from the system packaged node before downloading latest via nvm. I can try with a VM if you like but otherwise we can close this.

@jannis-baum
Copy link
Owner

Oki no worries! It was probably the yarn thing to be honest. If you check out the right old commit, run yarn there, and then go back and build, you can probably make it happen again.

The viv executable from the version on main will start the server and then wait until it's "healthy" to terminate. If the server crashes it won't terminate. This could happen because you had some module installed at a wrong version where it still compiles but crashes at runtime.

The new PR on ESM and config updates will change how the viv executable works. I think it's almost ready to merge, feel free to try it out as well :)

Anyways, will close this one now then

@Tweekism
Copy link
Collaborator Author

Hey mate,

I know we closed this one, but I hit the same issue when I got home. So I triple checked yarn was up to date. Manually deleted all the complied binaries just to be sure. Then ran make again and then vivify-server.

Output was:-

 $ viv .
Launching server ...
^C^
 $ vivify-server 
node:internal/util/embedding:41
    throw new ERR_UNKNOWN_BUILTIN_MODULE(path);
    ^

Error [ERR_UNKNOWN_BUILTIN_MODULE]: No such built-in module: node:sea
    at new NodeError (node:internal/errors:399:5)
    at embedderRequire (node:internal/util/embedding:41:11)
    at 8586 (/home/jason/.local/bin/vivify-server:2:2108635)
    at __webpack_require__ (/home/jason/.local/bin/vivify-server:2:3314800)
    at 365 (/home/jason/.local/bin/vivify-server:2:2043696)
    at __webpack_require__ (/home/jason/.local/bin/vivify-server:2:3314800)
    at 1859 (/home/jason/.local/bin/vivify-server:2:2036560)
    at __webpack_require__ (/home/jason/.local/bin/vivify-server:2:3314800)
    at /home/jason/.local/bin/vivify-server:2:3315484
    at /home/jason/.local/bin/vivify-server:2:3315511 {
  code: 'ERR_UNKNOWN_BUILTIN_MODULE'
}

Node.js v20.0.0

# Ran this to check my node version to confirm i had it set to v20.0.0 for some reason
 $ node --version
v20.0.0

So I updated node to latest (v22.4.1) and that fixed it.

@jannis-baum
Copy link
Owner

Ah, yes, seems like that's a version of Node from before they introduced SEA. We should figure out what exactly is the minimal working version and document that. Maybe you could add that to your current PR that is related the to Node distribution?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants