Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Markdown render error causes "file not found" #136

Closed
jannis-baum opened this issue Jul 27, 2024 · 0 comments · Fixed by #139
Closed

Markdown render error causes "file not found" #136

jannis-baum opened this issue Jul 27, 2024 · 0 comments · Fixed by #139
Labels
type:bug Something isn't working

Comments

@jannis-baum
Copy link
Owner

jannis-baum commented Jul 27, 2024

Problem is here:

body = renderTextFile(data.toString(), path);
}
} catch {
res.status(404).send('File not found.');

To reproduce, create a file with a duplicated custom id, e.g. by copying the whole "tests/markdown-extended.md" file and pasting it below itself again

Solution: handle render errors separately and give proper description

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant